[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27493 [Applications/Tor Browser]: 'mk_add_options' or 'export' MOZILLA_OFFICIAL

#27493: 'mk_add_options' or 'export' MOZILLA_OFFICIAL
--------------------------------------+--------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  enhancement               |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by reportUrl):

 Replying to [ticket:27493 sysrqb]:
 > In #27472, we added `export MOZILLA_OFFICIAL=1` in `.mozconfig-android`
 because we found the compiled APK wasn't releasable (it was still
 debuggable). This was due to MOZILLA_OFFICIAL not being set correctly at
 build-time. After exporting MOZILLA_OFFICIAL, the resulting APK is for
 release. Do we need both `mk_add_options` and `export` or do we only need
 `export`?
 Where did you get that `mk_add_options` trash? From pre-esr era? Mozilla
 removed almost all occurences of it, read https://dxr.mozilla.org/mozilla-
 esr60/source/build/docs/mozconfigs.rst#31
 > Should we use `export` on the desktop builds, too?
 Not you, but tbb-team, and long ago. That's #27623 now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27493#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs