[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27675 [Core Tor/Tor]: test_rebind.py depends on python >=2.7 or >=3.1 (was: test_rebind.py breaks on macOS, depends on python >=2.7 or >=3.1)

#27675: test_rebind.py depends on python >=2.7 or >=3.1
--------------------------+------------------------------------
 Reporter:  catalyst      |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Old description:

> It looks like test_rebind.py added as part of #17873 doesn't work for me
> on macOS 10.12.6, which has python 2.6.  test_rebind.py uses
> `str.format()` without a field name or number, which is new in python 2.7
> or 3.1.  It also tries to run with python3 (for unknown reasons), but
> ends up not necessarily doing so because test_rebind.sh explicitly runs
> `$PYTHON` or `python`.
>
> Replacing instances of `{}` in format strings with `{0}` seems to work.
>
> What is our minimum required python version anyway?

New description:

 It looks like test_rebind.py added as part of #17873 doesn't work for me
 ~~on macOS 10.12.6, which has~~ with python 2.6.  test_rebind.py uses
 `str.format()` without a field name or number, which is new in python 2.7
 or 3.1.  It also tries to run with python3 (for unknown reasons), but ends
 up not necessarily doing so because test_rebind.sh explicitly runs
 `$PYTHON` or `python`.

 Replacing instances of `{}` in format strings with `{0}` seems to work.

 What is our minimum required python version anyway?

--

Comment (by catalyst):

 I had a wayward python 2.6 in my PATH in front of /usr/bin.  It looks like
 macOS 10.12 has python 2.7.

 It might still be a good idea to delete the misleading
 `#!/usr/bin/python3` from test_rebind.py.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27675#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs