[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26381 [Applications/Tor Browser]: about:tor page does not load on first start on Windows and browser is stuck in endless reload cycle



#26381: about:tor page does not load on first start on Windows and browser is stuck
in endless reload cycle
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, ff60-esr,             |  Actual Points:
  TorBrowserTeam201809                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-torbutton, ff60-esr, TorBrowserTeam201808R,
     TorBrowserTeam201809R => tbb-torbutton, ff60-esr, TorBrowserTeam201809
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:31 brade]:
 > Mark and I spent some time looking at potential problems with making
 this change. Tor Launcher intentionally hooks in early so it can
 temporarily block certain things such as network activity.
 >
 > We specifically looked at the code that executes between `profile-after-
 change` and `final-ui-startup`. Here are the things we saw that concerned
 us:
 >
 > * Command line processing. This will not cause problems because the
 final processing that handles things such as URLs passed on the command
 line is deferred until after `final-ui-startup`.
 > * Creation of the hidden window. As far as Mark and I know, the hidden
 window is mainly used to support event processing and Mac menu commands.
 Therefore, we don't think it will be a problem if the hidden window is
 created before Tor Launcher is loaded.
 > * Startup of components that have the `profile-after-change` category.
 We think this one is an issue. For example, after applying the proposed
 fix we saw the update service attempt an update ping while the Tor
 Launcher initial configuration window was open.

 Nice find. It seems we need something else here. The two options proposed
 in the Mozilla ticket did not seem to make bobowen happy. Could we cheat
 the startupcache here? It seems getting rid of that one "solves" the
 problem as well (but I have not looked exactly why and whether we might be
 able to just remove the single piece in it that is troubling us)...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26381#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs