[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27224 [Core Tor/Tor]: Call node_get_all_orports() less from node_is_a_configured_bridge()
#27224: Call node_get_all_orports() less from node_is_a_configured_bridge()
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: rl1987
Type: enhancement | Status: closed
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 035-roadmap-master, 035-triaged- | implemented
in-20180711 | Actual Points:
Parent ID: #26630 | Points:
Reviewer: teor | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Changes (by nickm):
* status: needs_review => closed
* resolution: => implemented
Comment:
To test this, when I squashed the branch, I tried taking only the unit
tests, with none of the bridges.c changes, and making sure that they
passed on the old bridges.c code as well as the new. They did! So,
that's good.
But then I was worried that you hadn't tested the case where a bridge had
a matching address but a mismatched digest. In fact, I thought it wouldn't
work, since I had forgotten how
`get_configured_bridge_by_addr_port_digest` actually behaved... So I added
a test for that too -- and the code still passes before and after.
Nicely done! I think this code is correct.
I'm merging `bug27224_take2_squashed` to master now. It's the same as
your branch, squashed and rearranged, with an extra test.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27224#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs