[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27335 [Core Tor/Tor]: Tor bug when hs directory is missing

#27335: Tor bug when hs directory is missing
--------------------------+------------------------------------
 Reporter:  traumschule   |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.4.6-rc
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by dgoulet):

 Ok so another thing pointed out by traumschule on IRC.

 We shouldn't have the `BUG()` there because it will fail if the directory
 did not exists before. In `hs_config.c`, we don't try to create it so the
 check will pass if it doesn't exists, and then when loading the keys,
 we'll create the directory but we could still have the permission issues
 leading to the `BUG()` being triggered but shouldn't have.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27335#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs