[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27194 [Core Tor/Tor]: handling extra commas in protover

#27194: handling extra commas in protover
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.4-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, security-low, 029-backport,    |  Actual Points:
  032-backport, 033-backport, 034-backport       |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Just chatted with Nick on IRC about this. Can't this patch be simplified
 into: `s = comma + 1;` and then let the outer `while (s < end_of_entry)`
 take care of whether we are done processing the entry?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27194#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs