[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27097 [Applications/Tor Browser]: Add "Tor News" newsletter signup link in Tor Browser

#27097: Add "Tor News" newsletter signup link in Tor Browser
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-fundraising,            |  Actual Points:
  TorBrowserTeam201809, tbb-8.0.1-can            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:26 gk]:

 Thanks for the review!

 > Looks good! One small thing:
 > {{{
 > +    const kAboutTorHideTorNewsBanner = this.kAboutTorHideTorNewsBanner;
 > }}}
 > just remove that line and use `this.kAboutTorHideTorNewsBanner` in the
 two instances needed directly. Having a `kAboutTorHideTorNewsBanner` in
 the function scope and declared above is confusing and seems not worth it.

 Good catch. Here's a revised version where I fix that and rebased to the
 latest master.

 https://github.com/arthuredelstein/torbutton/commit/27097+6

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27097#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs