[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27139 [Core Tor/Tor]: macOS i386 fails time unit tests

#27139: macOS i386 fails time unit tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, macos, i386,             |  Actual Points:
  034-backport, arm32, 32-bit                    |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me!  I only tested using nickm's strategy of forcing the use
 of the 32-bit computation on 64-bit, and trust teor's evidence.

 I'm a little nervous about some of the fixed-point hackery here, but given
 that it's increasingly unlikely that 32-bit macOS will continue to be
 relevant, I guess we can fix it later if it turns out to be a problem.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27139#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs