[tor-bugs] #27918 [Core Tor/sbws]: Add types to some new arguments

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27918: Add types to some new arguments
-------------------------------+--------------------
     Reporter:  pastly         |      Owner:  (none)
         Type:  defect         |     Status:  new
     Priority:  Medium         |  Milestone:
    Component:  Core Tor/sbws  |    Version:
     Severity:  Normal         |   Keywords:
Actual Points:                 |  Parent ID:
       Points:                 |   Reviewer:
      Sponsor:                 |
-------------------------------+--------------------
 Because if you don't, they default to strings and that's not good.

 {{{
 $ sbws generate -n 1
 [... snip ...]
 Traceback (most recent call last):
   File "/home/matt/src/simple-bw-scanner/venv-editable/bin/sbws", line 11,
 in <module>
     load_entry_point('sbws', 'console_scripts', 'sbws')()
   File "/home/matt/src/simple-bw-scanner/sbws/sbws.py", line 75, in main
     exit(comm['f'](*comm['a'], **comm['kw']))
   File "/home/matt/src/simple-bw-scanner/sbws/core/generate.py", line 99,
 in main
     min_num=args.min_num)
   File "/home/matt/src/simple-bw-scanner/sbws/lib/v3bwfile.py", line 474,
 in from_results
     min_num)
   File "/home/matt/src/simple-bw-scanner/sbws/lib/v3bwfile.py", line 279,
 in from_results
     min_num)
   File "/home/matt/src/simple-bw-scanner/sbws/lib/v3bwfile.py", line 326,
 in min_num_results
     if len(results) > min_num:
 TypeError: unorderable types: int() > str()
 }}}

 `-p`, `-a`, and `-n` all need a type I bet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27918>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs