[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31634 [Core Tor/Tor]: Check .may_include order and tor subsystem init order are compatible

#31634: Check .may_include order and tor subsystem init order are compatible
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  diagnostics, 042-should,             |  Actual Points:
  practracker                                    |
Parent ID:  #31615                               |         Points:  2
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:2 nickm]:
 > Replying to [comment:1 teor]:
 > > We might also want to check against the order in subsystem_list.c.
 >
 > Yes, but have a look at check_and_setup() in subsysmgr.c -- that causes
 tor to exit with an assertion failure on startup if the subsystems are not
 sorted by priority.

 So we don't need to check the order in subsystem_list.c, because tor does
 it for us. That's good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31634#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs