[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting



#31594: Close all the log fds before aborting
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  diagnostics, 042-should, android,    |  Actual Points:  0.5
  macos, 035-backport, 040-backport,             |
  041-backport                                   |
Parent ID:  #31571                               |         Points:  0.3
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:6 teor]:
 > Replying to [comment:5 nickm]:
 > > I've left a couple of comments on the review. I've not reviewed the
 fsync commit, and I haven't checked that the new list of levels on the
 subsystems matches their dependency order or their order in
 subsystem_list.c.
 >
 > I didn't modify subsystem_list.c, I'll fix it when I revise the branch.
 > The subsystem levels vs subsystem_list.c order could be a unit test?
 > I'll see if I can make that happen.

 They are already a test on tor startup:
 https://trac.torproject.org/projects/tor/ticket/31634#comment:3

 So our CI won't pass if we mess this order up. (Any check that launches
 tor should fail, including keys, zero-length files, rebind, chutney and
 stem.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31594#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs