[tor-commits] [onionoo/master] Avoid parameter assignment.

[karsten@xxxxxxxxxxxxxx]

commit f47edf0b1d5fcfb3176182a3d9c602398d98f7f7
Author: Karsten Loesing <karsten.loesing@xxxxxxx>
Date:   Thu Mar 20 13:14:09 2014 +0100

    Avoid parameter assignment.
    
    Found by SonarQube.
---
 src/org/torproject/onionoo/NodeStatus.java |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/org/torproject/onionoo/NodeStatus.java b/src/org/torproject/onionoo/NodeStatus.java
index 1c3983e..78a08c2 100644
--- a/src/org/torproject/onionoo/NodeStatus.java
+++ b/src/org/torproject/onionoo/NodeStatus.java
@@ -508,9 +508,8 @@ public class NodeStatus extends Document {
     if (contact == null) {
       this.contact = null;
     } else {
-      contact = contact.toLowerCase();
       StringBuilder sb = new StringBuilder();
-      for (char c : contact.toCharArray()) {
+      for (char c : contact.toLowerCase().toCharArray()) {
         if (c >= 32 && c < 127) {
           sb.append(c);
         } else {



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits