[tor-commits] [tor/maint-0.4.0] circuitpadding: comment fixes

[asn@xxxxxxxxxxxxxx]

commit da678213e00cfe54ccc80286bed2b36603bba115
Author: teor <teor@xxxxxxxxxxxxxx>
Date:   Wed Apr 3 13:40:06 2019 +1000

    circuitpadding: comment fixes
---
 src/core/or/circuitpadding.c   | 3 ++-
 src/test/test_circuitpadding.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/core/or/circuitpadding.c b/src/core/or/circuitpadding.c
index ba6bfe1f5..0e3dc502c 100644
--- a/src/core/or/circuitpadding.c
+++ b/src/core/or/circuitpadding.c
@@ -1466,7 +1466,8 @@ circpad_estimate_circ_rtt_on_send(circuit_t *circ,
 
     /* If the old RTT estimate is lower than this one, use this one, because
      * the circuit is getting longer. If this estimate is somehow
-     * faster than the previous, then maybe that was network jitter.
+     * faster than the previous, then maybe that was network jitter, or a
+     * bad monotonic clock source (so our ratchet returned a zero delta).
      * In that case, average them. */
     if (mi->rtt_estimate_usec < (circpad_delay_t)rtt_time) {
       mi->rtt_estimate_usec = (circpad_delay_t)rtt_time;
diff --git a/src/test/test_circuitpadding.c b/src/test/test_circuitpadding.c
index ed048ab96..09a4c9a0c 100644
--- a/src/test/test_circuitpadding.c
+++ b/src/test/test_circuitpadding.c
@@ -576,7 +576,7 @@ test_circuitpadding_token_removal_higher(void *arg)
     }
   }
 
-  /* Check that all lowe bins are not touched */
+  /* Check that all lower bins are not touched */
   for (i=0; i < 4 ; i++) {
     tt_int_op(mi->histogram[i], OP_EQ, 2);
   }



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits