[tor-commits] [nyx/master] Blank debug path caused crashes

[atagar@xxxxxxxxxxxxxx]

commit 2602073521f7269ea70cde8a1208c3e275e3bd8f
Author: Damian Johnson <atagar@xxxxxxxxxxxxxx>
Date:   Tue Aug 28 09:01:07 2018 -0700

    Blank debug path caused crashes
    
    Great catch from traumschule that an empty path here causes us to crash...
    
      https://trac.torproject.org/projects/tor/ticket/27350
---
 nyx/starter.py           | 2 +-
 web/changelog/index.html | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/nyx/starter.py b/nyx/starter.py
index 08ac963..ab2c25c 100644
--- a/nyx/starter.py
+++ b/nyx/starter.py
@@ -131,7 +131,7 @@ def _setup_debug_logging(args):
 
   debug_dir = os.path.dirname(args.debug_path)
 
-  if not os.path.exists(debug_dir):
+  if debug_dir and not os.path.exists(debug_dir):
     os.makedirs(debug_dir)
 
   debug_handler = logging.FileHandler(args.debug_path, mode = 'w')
diff --git a/web/changelog/index.html b/web/changelog/index.html
index 7f0b2a1..e033e34 100644
--- a/web/changelog/index.html
+++ b/web/changelog/index.html
@@ -72,6 +72,7 @@
           <ul>
             <li>Connect by default to Tor Browser's default port (9151) when it's available</li>
             <li>Nyxrc <b>color_override</b> configuration values only worked if camel case (:trac:`26026`)</li>
+            <li>Blank debug path caused us to crash (:trac:`27350`)</li>
           </ul>
         </li>
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits