[tor-commits] [tor/maint-0.3.5] Fix a logic error in deciding whether to accept SessionGroup=

[teor@xxxxxxxxxxxxxx]

commit 70b85358afd0a8d4291489f9e9f5654ab2d53371
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Fri May 31 08:26:10 2019 -0400

    Fix a logic error in deciding whether to accept SessionGroup=
    
    Fixes bug 22619; bugfix on 0.2.7.2-alpha
---
 changes/bug22619        | 3 +++
 src/app/config/config.c | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/changes/bug22619 b/changes/bug22619
new file mode 100644
index 000000000..9c71996f5
--- /dev/null
+++ b/changes/bug22619
@@ -0,0 +1,3 @@
+  o Minor bugfixes (circuit isolation):
+    - Fix a logic error that prevented the SessionGroup sub-option from
+      being accepted. Fixes bug 22619; bugfix on 0.2.7.2-alpha.
diff --git a/src/app/config/config.c b/src/app/config/config.c
index 2a504d306..352559759 100644
--- a/src/app/config/config.c
+++ b/src/app/config/config.c
@@ -7080,7 +7080,7 @@ parse_port_config(smartlist_t *out,
         if (!strcasecmpstart(elt, "SessionGroup=")) {
           int group = (int)tor_parse_long(elt+strlen("SessionGroup="),
                                           10, 0, INT_MAX, &ok, NULL);
-          if (!ok || !allow_no_stream_options) {
+          if (!ok || allow_no_stream_options) {
             log_warn(LD_CONFIG, "Invalid %sPort option '%s'",
                      portname, escaped(elt));
             goto err;



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits