[tor-commits] [tor/master] Fix a leak-on-failure on test_get_bandwidth_lines()

[nickm@xxxxxxxxxxxxxx]

commit efe8a988172422285762459e820d3cbcce5a6b10
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Sat Aug 1 09:29:08 2020 -0400

    Fix a leak-on-failure on test_get_bandwidth_lines()
    
    Spotted by coverity. This is CID 1465571.
---
 src/test/test_stats.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/test/test_stats.c b/src/test/test_stats.c
index ecf8f9a7d5..b6849b0b6d 100644
--- a/src/test/test_stats.c
+++ b/src/test/test_stats.c
@@ -452,7 +452,7 @@ static void
 test_get_bandwidth_lines(void *arg)
 {
   (void) arg;
-  char *str, *checkstr;
+  char *str = NULL, *checkstr = NULL;
   char t[ISO_TIME_LEN+1];
   int len = (67+MAX_HIST_VALUE_LEN)*4;
   checkstr = tor_malloc_zero(len);
@@ -486,7 +486,9 @@ test_get_bandwidth_lines(void *arg)
                     "2048,29696,14336,59392,29696\n",
                     t, t, t, t);
   test_get_bw_lines(str, checkstr);
+
  done:
+  tor_free(str);
   tor_free(checkstr);
   bwhist_free_all();
 }

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits