[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser-build][main] Bug 26408: Remove redundant check of macos code signature in update_responses

Title: GitLab

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build

Commits:

  • 4e6d2832
    by Nicolas Vigier at 2025-08-21T16:44:40+02:00 
    Bug 26408: Remove redundant check of macos code signature in update_responses

When CHECK_CODESIGNATURE_EXISTS is set (we set it when re-generating
incrementals for macos during the signing process), we were checking
that both the mar files from previous and new versions are code signed.
Checking that the mar file from the previous version is code signed is
not necessary since it is checked just before even when the
CHECK_CODESIGNATURE_EXISTS is not set.

1 changed file:

Changes:

  • tools/update-responses/update_responses
    ... ... @@ -261,11 +261,11 @@ sub create_incremental_mar {
    261 261 
                     && ! -f "$tmpdir/A/Contents/_CodeSignature/CodeResources") {
    262 262 
             exit_error "Missing code signature in $from_version while creating $mar_file";
    263 263 
         }
    264 
    +    # Check that the version we update to is code signed (when re-generating
    265 
    +    # incrementals for macos during the signing process)
    264 266 
         if ($ENV{CHECK_CODESIGNATURE_EXISTS}) {
    265 
    -        unless (-f "$tmpdir/A/Contents/_CodeSignature/CodeResources"
    266 
    -            && -f "$tmpdir/B/Contents/_CodeSignature/CodeResources") {
    267 
    -            exit_error "Missing code signature while creating $mar_file";
    268 
    -        }
    267 
    +        exit_error "Missing code signature while creating $mar_file"
    268 
    +            unless -f "$tmpdir/B/Contents/_CodeSignature/CodeResources";
    269 269 
         }
    270 270 
         local $ENV{MOZ_PRODUCT_VERSION} = $new_version;
    271 271 
         local $ENV{MAR_CHANNEL_ID} = get_config($config, $new_version, $os, 'mar_channel_id');

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/4e6d283256c2f1c11585ad196949f1e38a6d81d3 at 1756124111 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx