[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [or-cvs] betcha didn"t know strncpy could leave an unterminatedstring

To: or-dev@freehaven.net
Subject: Re: [or-cvs] betcha didn"t know strncpy could leave an unterminatedstring
From: Ben Laurie <ben@algroup.co.uk>
Date: Wed, 17 Dec 2003 13:52:43 +0000
Cc: or-cvs@freehaven.net
Delivered-to: archiver@seul.org
Delivered-to: or-cvs-outgoing@seul.org
Delivered-to: or-cvs@seul.org
Delivery-date: Wed, 17 Dec 2003 08:53:24 -0500
In-reply-to: <20031217092031.D25AC33C55@moria.seul.org>
References: <20031217092031.D25AC33C55@moria.seul.org>
Reply-to: or-dev@freehaven.net
Sender: owner-or-cvs@freehaven.net
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031205 Thunderbird/0.4

Roger Dingledine wrote:

Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
dirserv.c dns.c Log Message:
betcha didn't know strncpy could leave an unterminated string

Did actually - that's why you should use strlcpy and strlcat instead. Another thing that's bad about strncpy is it NUL _fills_ which can be a significant cost if you use large buffers.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

References:
- [or-cvs] betcha didn"t know strncpy could leave an unterminated string
  - From: arma@seul.org (Roger Dingledine)

Next by Author: [or-cvs] Make router/directory parsing nondestructive and more const...
Previous by thread: [or-cvs] betcha didn"t know strncpy could leave an unterminated string
Next by thread: [or-cvs] make fetch_from_buf_http malloc its strings rather
Index(es):
- Author
- Thread