[tor-commits] [ooni-probe/master] Explicitly state that reactor.stop and reactor.start should not be called from inside test methods

[art@xxxxxxxxxxxxxx]

commit 53ed7f69ff809e20eeaaaa4e3797e1da155de6a2
Author: Arturo Filastò <art@xxxxxxxxx>
Date:   Sun Dec 9 14:01:16 2012 +0100

    Explicitly state that reactor.stop and reactor.start should not be called from inside test methods
---
 docs/source/writing_tests.rst |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/docs/source/writing_tests.rst b/docs/source/writing_tests.rst
index 4ce6268..ccc529a 100644
--- a/docs/source/writing_tests.rst
+++ b/docs/source/writing_tests.rst
@@ -25,6 +25,10 @@ Tests are driven by inputs. For every input a new test instance is created,
 internally the _setUp method is called that is defined inside of test
 templates, then the setUp method that is overwritable by users.
 
+Gotchas:
+**never** call reactor.start of reactor.stop inside of your test method and all
+will be good.
+
 Inputs
 ------
 

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits