[tor-commits] [tor/master] Remove a double-free in test_single_onion_poisoning

[nickm@xxxxxxxxxxxxxx]

commit fdd368d6564e955422337af53e0723b571b8da57
Author: teor <teor2345@xxxxxxxxx>
Date:   Sat Dec 3 06:27:32 2016 +1100

    Remove a double-free in test_single_onion_poisoning
    
    We were freeing both dir{1,2} directly, and service_{1,2}->directory via
    rend_service_free, even though they are the same pointer.
---
 src/test/test_hs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/test_hs.c b/src/test/test_hs.c
index 1039c64..c7aaace 100644
--- a/src/test/test_hs.c
+++ b/src/test/test_hs.c
@@ -570,8 +570,8 @@ test_single_onion_poisoning(void *arg)
     tt_assert(ret == 0);
   }
 
-  service_1->directory = dir1;
-  service_2->directory = dir2;
+  service_1->directory = tor_strdup(dir1);
+  service_2->directory = tor_strdup(dir2);
   /* The services own the directory pointers now */
   dir1 = dir2 = NULL;
   /* Add port to service 1 */



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits