[tor-commits] [tor/master] Note some large functions that could be split.

[nickm@xxxxxxxxxxxxxx]

commit 46619ec9143450b181a8510011d3e3fd92542aa4
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Tue Nov 29 11:34:37 2016 -0500

    Note some large functions that could be split.
    
    George Kadianakis pointed these out.
---
 src/or/entrynodes.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/or/entrynodes.c b/src/or/entrynodes.c
index 004081e..af1869f 100644
--- a/src/or/entrynodes.c
+++ b/src/or/entrynodes.c
@@ -1099,6 +1099,7 @@ entry_guard_is_listed(guard_selection_t *gs, const entry_guard_t *guard)
 STATIC void
 sampled_guards_update_from_consensus(guard_selection_t *gs)
 {
+  /*XXXX prop271 consider splitting this function up. */
   tor_assert(gs);
   const int REMOVE_UNLISTED_GUARDS_AFTER =
     (get_remove_unlisted_guards_after_days() * 86400);
@@ -1503,6 +1504,7 @@ make_guard_confirmed(guard_selection_t *gs, entry_guard_t *guard)
 STATIC void
 entry_guards_update_primary(guard_selection_t *gs)
 {
+  /*XXXX prop271 consider splitting this function up. */
   tor_assert(gs);
 
   // prevent recursion. Recursion is potentially very bad here.
@@ -1697,6 +1699,7 @@ entry_guards_note_internet_connectivity(guard_selection_t *gs)
 STATIC entry_guard_t *
 select_entry_guard_for_circuit(guard_selection_t *gs, unsigned *state_out)
 {
+  /*XXXX prop271 consider splitting this function up. */
   tor_assert(gs);
   tor_assert(state_out);
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits