[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-140.6.0esr-15.0-1] Bug 1995637 - Make sure debugger object gets traced when tracing breakpoints r=iain

Title: GitLab

ma1 pushed to branch tor-browser-140.6.0esr-15.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • c483e297
    by Jon Coppeard at 2025-12-05T21:55:37+01:00 
    Bug 1995637 - Make sure debugger object gets traced when tracing breakpoints r=iain

Breakpoints currently trace |wrappedDebugger| but this doesn't keep |debugger|
alive if we have nuked the CCWs. The debugger has a linked list of breakpoints that
each breakpoint is part of so we need to make sure it lives at least as long as
that.

The patch traces the debugger's object even if our CCW to it has been nuked.

Differential Revision: https://phabricator.services.mozilla.com/D271062

2 changed files:

Changes:

  • js/src/debugger/Debugger.cpp
    ... ... @@ -454,6 +454,9 @@ Breakpoint::Breakpoint(Debugger* debugger, HandleObject wrappedDebugger,
    454 454
    455 455 
     void Breakpoint::trace(JSTracer* trc) {
    456 456 
       TraceEdge(trc, &wrappedDebugger, "breakpoint owner");
    457 
    +  // Trace the debugger object too in case |wrappedDebugger| got nuked.
    458 
    +  TraceCrossCompartmentEdge(trc, wrappedDebugger, &debugger->object,
    459 
    +                            "breakpoint debugger object");
    457 460 
       TraceEdge(trc, &handler, "breakpoint handler");
    458 461 
     }
    459 462

  • js/src/jit-test/tests/debug/bug-1995637.js
    1 
    +// |jit-test| error: TypeError
    2 
    +gczeal(9,16);
    3 
    +function F1() {
    4 
    +    if (!new.target) { throw 'must be called with new'; }
    5 
    +    this.b = null;
    6 
    +}
    7 
    +new F1();
    8 
    +new F1();
    9 
    +function f5() {}
    10 
    +new BigUint64Array(3474);
    11 
    +function f14() {}
    12 
    +function f25(a26, a27) {
    13 
    +    for (let i30 = 0, i31 = true; i31; i31--) {
    14 
    +        function f37() {
    15 
    +            function F38() {}
    16 
    +            for (let i44 = 0, i45 = SharedArrayBuffer; i45;
    17 
    +                (() => {
    18 
    +                    i45--;
    19 
    +                    Int8Array.principal = BigUint64Array;
    20 
    +                    function F50() {}
    21 
    +                    Int8Array.sameZoneAs = /wp(?:a?)+/imu;
    22 
    +                    const v54 = this.newGlobal(Int8Array);
    23 
    +                    const t7 = ({ __proto__: v54 }).Debugger;
    24 
    +                    const v57 = t7(F50);
    25 
    +                    const v59 = v57.getNewestFrame(i30, i45, i45, f25, v57).older;
    26 
    +                    v59.script.setBreakpoint(16, v59);
    27 
    +                })()) {}
    28 
    +            for (let [i134, i135] = (() => {
    29 
    +                    for (let i84 = 0, i85 = 10; i85;
    30 
    +                        (() => {
    31 
    +                            i85--;
    32 
    +                            for (let [i102, i103] = (() => {
    33 
    +                                    for (let [i95, i96] = (() => {
    34 
    +                                            new Uint8Array();
    35 
    +                                            return [0, 10];
    36 
    +                                        })(); i96; i96--) {
    37 
    +                                    }
    38 
    +                                    return [0, SharedArrayBuffer];
    39 
    +                                })();
    40 
    +                                i103; i103--) {}
    41 
    +                            for (let i113 = -4, i114 = 10; i114; i114--) {}
    42 
    +                            for (let i122 = 4, i123 = 10; i123--, i123; i123--) {
    43 
    +                                i123++;
    44 
    +                            }
    45 
    +                        })()) {}
    46 
    +                    return [0, SharedArrayBuffer];
    47 
    +                })();
    48 
    +                i135; i135--) {            }
    49 
    +            for (let i143 = 0, i144 = 10; i144; i144--) {}
    50 
    +        }
    51 
    +        f37.apply();
    52 
    +    }
    53 
    +    for (let i153 = 0, i154 = 10; i154; i154--) {}
    54 
    +    function F160(a162, a163) {
    55 
    +        if (!new.target) { throw 'must be called with new'; }
    56 
    +        this.c = a27;
    57 
    +        this.h = a162;
    58 
    +    }
    59 
    +    new F160(234, a27);
    60 
    +    const v167 = this.nukeAllCCWs();
    61 
    +    for (let i170 = 0, i171 = 10; i171; i171--) {}
    62 
    +    try {
    63 
    +        f25();
    64 
    +    } catch(e178) {}
    65 
    +}
    66 
    +f25(f25, f25);

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c483e2978d7591ce0f5df6fca3f1fe18317ba6d4 at 1765032092 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx