[tor-commits] [tor/master] Cleanup shellcheck warnings in autogen.sh

[dgoulet@xxxxxxxxxxxxxx]

commit 88818eacbdcbdd1fddb3452c3eddf8fba3f26e9c
Author: rl1987 <rl1987@xxxxxxxxxxxxxxxx>
Date:   Fri Jan 18 13:49:30 2019 +0200

    Cleanup shellcheck warnings in autogen.sh
---
 autogen.sh          | 5 +++--
 changes/ticket26069 | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/autogen.sh b/autogen.sh
index 276dd4047..63ef6d49e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,9 +1,9 @@
 #!/bin/sh
 
-if [ -x "`which autoreconf 2>/dev/null`" ] ; then
+if command -v autoreconf; then
   opt="-i -f -W all,error"
 
-  for i in $@; do
+  for i in "$@"; do
     case "$i" in
       -v)
         opt="${opt} -v"
@@ -11,6 +11,7 @@ if [ -x "`which autoreconf 2>/dev/null`" ] ; then
     esac
   done
 
+  # shellcheck disable=SC2086
   exec autoreconf $opt
 fi
 
diff --git a/changes/ticket26069 b/changes/ticket26069
new file mode 100644
index 000000000..caed9be34
--- /dev/null
+++ b/changes/ticket26069
@@ -0,0 +1,2 @@
+  o Code simplification and refactoring (shell scripts):
+    - Cleanup autogen.sh to silence shellcheck warnings. Closes ticket 26069.



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits