[tor-commits] [tor/release-0.4.5] relay: Fix Coverity warning for unchecked returned value

[ahf@xxxxxxxxxxxxxx]

commit 841ee4641ef75e2bb4c7400641ab257e67b6bcce
Author: David Goulet <dgoulet@xxxxxxxxxxxxxx>
Date:   Mon Feb 8 11:09:29 2021 -0500

    relay: Fix Coverity warning for unchecked returned value
    
    Signed-off-by: David Goulet <dgoulet@xxxxxxxxxxxxxx>
---
 src/feature/relay/router.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/feature/relay/router.c b/src/feature/relay/router.c
index 4bc71eb486..60f237a700 100644
--- a/src/feature/relay/router.c
+++ b/src/feature/relay/router.c
@@ -2673,9 +2673,13 @@ check_descriptor_ipaddress_changed(time_t now)
 
     /* Attempt to discovery the publishable address for the family which will
      * actively attempt to discover the address if we are configured with a
-     * port for the family. */
-    relay_find_addr_to_publish(get_options(), family, RELAY_FIND_ADDR_NO_FLAG,
-                               &current);
+     * port for the family.
+     *
+     * It is OK to ignore the returned value here since in the failure case,
+     * that is the address was not found, the current value is set to UNSPEC.
+     * Add this (void) so Coverity is happy. */
+    (void) relay_find_addr_to_publish(get_options(), family,
+                                      RELAY_FIND_ADDR_NO_FLAG, &current);
 
     /* The "current" address might be UNSPEC meaning it was not discovered nor
      * found in our current cache. If we had an address before and we have



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits