[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] 2 commits: fixup! Bug 1823316 - Use 'Snackbar' themed Dialog to notify on making app full-screen

Title: GitLab

ma1 pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android

Commits:

  • a57e5d10
    by hackademix at 2024-01-10T08:41:06+01:00 
    fixup! Bug 1823316 - Use 'Snackbar' themed Dialog to notify on making app full-screen

Fix tor-browser#42355 backporting regression.
  • c1397e81
    by t-p-white at 2024-01-10T08:41:06+01:00 
    Bug 1864549 - Fix for IllegalStateException in full screen notification dialog

2 changed files:

Changes:

  • android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/FullScreenNotificationDialog.kt
    ... ... @@ -59,11 +59,12 @@ class FullScreenNotificationDialog(@LayoutRes val layout: Int) :
    59 59 
                     window.setGravity(Gravity.BOTTOM)
    60 60 
                     window.clearFlags(WindowManager.LayoutParams.FLAG_DIM_BEHIND)
    61 61 
                 }
    62 
    +        }
    62 63
    63 
    -            lifecycleScope.launch {
    64 
    -                delay(SNACKBAR_DURATION_LONG_MS)
    65 
    -                dismiss()
    66 
    -            }
    64 
    +        // Attempt to automatically dismiss the dialog after the given duration.
    65 
    +        lifecycleScope.launch {
    66 
    +            delay(SNACKBAR_DURATION_LONG_MS)
    67 
    +            dialog?.dismiss()
    67 68 
             }
    68 69 
         }
    69 70 
     }

  • fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt
    ... ... @@ -1491,6 +1491,7 @@ abstract class BaseBrowserFragment :
    1491 1491 
                     parentFragmentManager,
    1492 1492 
                 )
    1493 1493
    1494 
    +            activity?.enterToImmersiveMode()
    1494 1495 
                 (view as? SwipeGestureLayout)?.isSwipeEnabled = false
    1495 1496 
                 browserToolbarView.collapse()
    1496 1497 
                 browserToolbarView.view.isVisible = false

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits