[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.1.0esr-13.0-1] fixup! Bug 40597: Implement TorSettings module

Title: GitLab

richard pushed to branch tor-browser-115.1.0esr-13.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • f0493f9f
    by Pier Angelo Vendrame at 2023-07-27T18:20:08+00:00 
    fixup! Bug 40597: Implement TorSettings module

Bug 41907: Change state after the process becomes ready only when we
are in the initial state.

1 changed file:

Changes:

  • browser/modules/TorConnect.jsm
    ... ... @@ -874,6 +874,18 @@ const TorConnect = (() => {
    874 874 
           switch (topic) {
    875 875 
             /* We need to wait until TorSettings have been loaded and applied before we can Quickstart */
    876 876 
             case TorSettingsTopics.Ready: {
    877 
    +          // tor-browser#41907: This is only a workaround to avoid users being
    878 
    +          // bounced back to the initial panel without any explanation.
    879 
    +          // Longer term we should disable the clickable elements, or find a UX
    880 
    +          // to prevent this from happening (e.g., allow buttons to be clicked,
    881 
    +          // but show an intermediate starting state, or a message that tor is
    882 
    +          // starting while the butons are disabled, etc...).
    883 
    +          if (this.state !== TorConnectState.Initial) {
    884 
    +            console.warn(
    885 
    +              "TorConnect: Seen the torsettings:ready after the state has already changed, ignoring the notification."
    886 
    +            );
    887 
    +            break;
    888 
    +          }
    877 889 
               if (this.shouldQuickStart) {
    878 890 
                 // Quickstart
    879 891 
                 this._changeState(TorConnectState.Bootstrapping);

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits