[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-153.0a1-16.0-2] fixup! BB 40925: Implemented the Security Level component

Title: GitLab

Dan Ballard pushed to branch tor-browser-153.0a1-16.0-2 at The Tor Project / Applications / Tor Browser

Commits:

  • 3c6db68e
    by clairehurst at 2026-07-14T11:33:28-07:00 
    fixup! BB 40925: Implemented the Security Level component

Bug 45109: No value passed for parameter 'jsEnabled'

4 changed files:

Changes:

  • mobile/android/android-components/components/feature/intent/src/main/java/mozilla/components/feature/intent/processing/TabIntentProcessor.kt
    ... ... @@ -48,7 +48,7 @@ class TabIntentProcessor(
    48 48 
         private val newTabSearchUseCase: SearchUseCases.NewTabSearchUseCase,
    49 49 
         private val isPrivate: Boolean = false,
    50 50 
         private val engine: Engine? = null,
    51 
    -    private val jsEnabled: Boolean,
    51 
    +    private val jsEnabled: Boolean = true,
    52 52 
     ) : IntentProcessor {
    53 53
    54 54 
         private val logger = Logger("TabIntentProcessor")

  • mobile/android/android-components/components/feature/search/src/main/java/mozilla/components/feature/search/SearchUseCases.kt
    ... ... @@ -26,7 +26,7 @@ class SearchUseCases(
    26 26 
         store: BrowserStore,
    27 27 
         tabsUseCases: TabsUseCases,
    28 28 
         sessionUseCases: SessionUseCases,
    29 
    -    jsEnabled: Boolean,
    29 
    +    jsEnabled: Boolean = true,
    30 30 
     ) {
    31 31 
         interface SearchUseCase {
    32 32 
             /**
    ... ... @@ -43,7 +43,7 @@ class SearchUseCases(
    43 43 
             private val store: BrowserStore,
    44 44 
             private val tabsUseCases: TabsUseCases,
    45 45 
             private val sessionUseCases: SessionUseCases,
    46 
    -        private val jsEnabled: Boolean,
    46 
    +        private val jsEnabled: Boolean = true,
    47 47 
         ) : SearchUseCase {
    48 48 
             private val logger = Logger("DefaultSearchUseCase")
    49 49
    ... ... @@ -134,7 +134,7 @@ class SearchUseCases(
    134 134 
             private val store: BrowserStore,
    135 135 
             private val tabsUseCases: TabsUseCases,
    136 136 
             private val isPrivate: Boolean,
    137 
    -        private val jsEnabled: Boolean,
    137 
    +        private val jsEnabled: Boolean = true,
    138 138 
         ) : SearchUseCase {
    139 139 
             private val logger = Logger("NewTabSearchUseCase")
    140 140
    ... ... @@ -172,7 +172,7 @@ class SearchUseCases(
    172 172 
                 parentSessionId: String? = null,
    173 173 
                 flags: EngineSession.LoadUrlFlags = EngineSession.LoadUrlFlags.none(),
    174 174 
                 additionalHeaders: Map<String, String>? = null,
    175 
    -            jsEnabled: Boolean,
    175 
    +            jsEnabled: Boolean = true,
    176 176 
             ) {
    177 177 
                 val resolvedEngine = searchEngine ?: store.state.search.selectedOrDefaultSearchEngine(isPrivate)
    178 178 
                 val searchUrl = resolvedEngine?.let {

  • mobile/android/android-components/components/feature/search/src/main/java/mozilla/components/feature/search/internal/SearchUrlBuilder.kt
    ... ... @@ -29,7 +29,7 @@ private const val OS_PARAM_OPTIONAL = "\\{" + "(?:\\w+:)?\\w+?" + "\\}"
    29 29 
     internal class SearchUrlBuilder(
    30 30 
         private val searchEngine: SearchEngine,
    31 31 
     ) {
    32 
    -    fun buildSearchUrl(searchTerms: String, jsEnabled: Boolean): String {
    32 
    +    fun buildSearchUrl(searchTerms: String, jsEnabled: Boolean = true): String {
    33 33 
             // The parser should have put the best URL for this device at the beginning of the list.
    34 34 
             var template = searchEngine.resultUrls[0]
    35 35 
             if (!jsEnabled && (searchEngine.id == "ddg" || searchEngine.id == "ddg-onion")) {

  • mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/usecases/FenixBrowserUseCases.kt
    ... ... @@ -34,7 +34,7 @@ class FenixBrowserUseCases(
    34 34 
         private val searchUseCases: SearchUseCases,
    35 35 
         private val homepageTitle: String,
    36 36 
         private val profiler: Profiler?,
    37 
    -    private val jsEnabled: Boolean,
    37 
    +    private val jsEnabled: Boolean = true,
    38 38 
     ) {
    39 39 
         /**
    40 40 
          * Loads a URL or performs a search depending on the value of [searchTermOrURL].

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3c6db68e14977c9ac67db2464077afe791f6f0d2 at 1784054228 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx