[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/mullvad-browser][mullvad-browser-153.0esr-16.0-1] 3 commits: fixup! Firefox preference overrides.

Title: GitLab

brizental pushed to branch mullvad-browser-153.0esr-16.0-1 at The Tor Project / Applications / Mullvad Browser

Commits:

  • d88f3275
    by Beatriz Rizental at 2026-07-22T22:46:50-03:00 
    fixup! Firefox preference overrides.

Bug 45120: Disable smartwindow feature
  • 622b3fe0
    by Beatriz Rizental at 2026-07-22T22:46:51-03:00 
    fixup! BB 44045: Disable ML features.

Bug 45120: Disable smartwindow feature

Even when disabled, this feature still was using the EngineProcess to
download models. I have made this conditional, because trying to use
that was causing a runtime error preventing initialization to complete
successfully and whenever a new window was opened e.g. through "Open
Link In New Window", the browser crashed completely.
  • f851d77f
    by Beatriz Rizental at 2026-07-22T22:46:52-03:00 
    BB 45120: Add tests for Base Browser

4 changed files:

Changes:

  • browser/app/profile/001-base-profile.js
    ... ... @@ -383,6 +383,8 @@ pref("pdfjs.enableAltTextModelDownload", false, locked);
    383 383 
     pref("browser.urlbar.quicksuggest.mlEnabled", false, locked);
    384 384 
     // Disable SemanticHistory search. tor-browser#44045.
    385 385 
     pref("places.semanticHistory.featureGate", false, locked);
    386 
    +// tor-browser#45120: Disable AIWindow
    387 
    +pref("browser.smartwindow.enabled", false);
    386 388
    387 389
    388 390 
     // tor-browser#41945 - disable automatic cookie banners dismissal until

  • browser/components/aiwindow/ui/modules/AIWindow.sys.mjs
    ... ... @@ -131,7 +131,11 @@ export const AIWindow = {
    131 131 
         Services.obs.addObserver(this, lazy.ONLOGOUT_NOTIFICATION);
    132 132 
         Services.obs.addObserver(this, "tabstrip-orientation-change");
    133 133 
         lazy.SmartWindowTelemetry.init();
    134 
    -    lazy.getAllModelsData(); // loads model data into cache for about:preferences
    134 
    +    if (this.isAIWindowEnabled()) {
    135 
    +      // Depends on the ml component, which tor-browser#44045 excludes from
    136 
    +      // the build, so only touch it when AI Window is actually enabled.
    137 
    +      lazy.getAllModelsData(); // loads model data into cache for about:preferences
    138 
    +    }
    135 139 
         lazy.NimbusFeatures.smartWindow.onUpdate(this.onNimbusUpdate);
    136 140 
         this._initialized = true;
    137 141

  • testing/base-browser/manifest.toml
    1 
    +[DEFAULT]
    2 
    +tags = "base-browser"
    3 
    +
    4 
    +["test_new_window.py"]

  • testing/base-browser/test_new_window.py
    1 
    +from marionette_harness import MarionetteTestCase, WindowManagerMixin
    2 
    +
    3 
    +
    4 
    +class TestNewWindow(WindowManagerMixin, MarionetteTestCase):
    5 
    +    def tearDown(self):
    6 
    +        self.close_all_windows()
    7 
    +        super().tearDown()
    8 
    +
    9 
    +    def test_open_new_window(self):
    10 
    +        with self.marionette.using_context("chrome"):
    11 
    +            new_window = self.open_window()
    12 
    +
    13 
    +        self.assertEqual(
    14 
    +            len(self.marionette.chrome_window_handles),
    15 
    +            len(self.start_windows) + 1,
    16 
    +            "A new browser window should have been opened.",
    17 
    +        )
    18 
    +
    19 
    +        self.marionette.switch_to_window(new_window)
    20 
    +        self.marionette.navigate("about:blank")
    21 
    +        self.assertEqual(
    22 
    +            self.marionette.get_url(),
    23 
    +            "about:blank",
    24 
    +            "Should be able to navigate in the newly opened window.",
    25 
    +        )

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/a8a167fe41226f38158d8e169623e95a1bff846a...f851d77f12f4cfd3e3b1078b9c3f5e6708d3bf10 at 1784771219 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx