[or-cvs] r15566: Add in some comments from code review. (torflow/branches/gsoc2008)

[mikeperry@xxxxxxxx]

Author: mikeperry
Date: 2008-06-29 18:54:47 -0400 (Sun, 29 Jun 2008)
New Revision: 15566

Modified:
   torflow/branches/gsoc2008/soat.py
Log:

Add in some comments from code review.



Modified: torflow/branches/gsoc2008/soat.py
===================================================================
--- torflow/branches/gsoc2008/soat.py	2008-06-29 21:45:43 UTC (rev 15565)
+++ torflow/branches/gsoc2008/soat.py	2008-06-29 22:54:47 UTC (rev 15566)
@@ -55,6 +55,8 @@
 # links of interest
 #
 
+# FIXME: Turn these into a keyword list that causes us to get semi-random
+# google results in a few different languages
 docs_http = ['http://www.torproject.org','http://www.math.ut.ee','http://www.mozilla.com']
 docs_https = ['mail.google.com','addons.mozilla.org','www.paypal.com','www.fastmail.fm']
 docs_ssh = []
@@ -413,6 +415,9 @@
             return TEST_FAILURE
 
         # if comparsion fails, replace the old cert with the new one
+        # XXX: Hrmm, probably should store as a seperate IP file in this case
+        # so we don't keep alternating on sites that have round robin
+        # DNS and different certs for each IP.. 
         cert_file = open(ssl_certs_dir + address + '.pem', 'w')
         cert_file.write(original_cert_new_pem)
         cert_file.close()
@@ -605,6 +610,10 @@
     # plog('NOTICE', 'Final URL list: ' + '\n'.join(doc_urls) + '\n')
 
     # get the number of nodes that need to be tested
+    # XXX: Need to update this periodically for this to work.. But 
+    # it probably shouldn't be used for a termination condition anyways..
+    # It is probably good to ballpark if we've done all exits for 
+    # informational purposes, but then we should just restart the scan
     ssl_nodes = len(scanner.get_nodes_for_port(443))
     http_nodes = len(scanner.get_nodes_for_port(80))
     ssh_nodes = len(scanner.get_nodes_for_port(22))