[tor-commits] [sbws/master] Clarify why not trimming results on IP changes

[pastly@xxxxxxxxxxxxxx]

commit 59f6d6089d938f9530838be449c9ad5c220f983e
Author: juga0 <juga@xxxxxxxxxx>
Date:   Tue Jun 19 19:58:36 2018 +0000

    Clarify why not trimming results on IP changes
    
    when storing the results.
---
 sbws/lib/resultdump.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sbws/lib/resultdump.py b/sbws/lib/resultdump.py
index cadc825..31a8926 100644
--- a/sbws/lib/resultdump.py
+++ b/sbws/lib/resultdump.py
@@ -500,9 +500,10 @@ class ResultDump:
                 self.data[fp] = []
             self.data[fp].append(result)
             self.data = trim_results(self.fresh_days, self.data)
-            # we probably do not want to remove the results for a relay
-            # that has changed address when storing the results
-            # it will be already done when loading
+            # Not calling trim_results_ip_changed here to do not remove
+            # the results for a relay that has changed address.
+            # It will be called when loading the results to generate a v3bw
+            # file.
 
     def handle_result(self, result):
         ''' Call from ResultDump thread. If we are shutting down, ignores



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits