... |
... |
@@ -25,12 +25,34 @@ |
25
|
25
|
|
26
|
26
|
### Merging
|
27
|
27
|
- [ ] Merge to `tor-browser` - `!fixups` to `tor-browser`-specific commits, new features, security backports
|
28
|
|
-- [ ] Merge to `base-browser` -`!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports
|
|
28
|
+- [ ] Merge to `base-browser` - `!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports
|
29
|
29
|
- **NOTE**: if your changeset includes patches to both `base-browser` and `tor-browser` please clearly label in the change description which commits should be cherry-picked to `base-browser` after merging
|
30
|
30
|
|
31
|
31
|
### Issue Tracking
|
32
|
32
|
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
|
33
|
33
|
|
34
|
|
-## Change Description
|
35
|
|
-
|
36
|
|
-<!-- Whatever context the reviewer needs to effectively review the patchset --> |
|
|
\ No newline at end of file |
|
34
|
+### Review
|
|
35
|
+
|
|
36
|
+#### Request Reviewer
|
|
37
|
+
|
|
38
|
+- [ ] Request review from an applications developer depending on modified system:
|
|
39
|
+ - **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
|
|
40
|
+ - **accessibility** : henry
|
|
41
|
+ - **android** : dan
|
|
42
|
+ - **build system** : boklm
|
|
43
|
+ - **extensions** : ma1
|
|
44
|
+ - **firefox internals (XUL/JS/XPCOM)** : ma1
|
|
45
|
+ - **fonts** : pierov
|
|
46
|
+ - **frontend (implementation)** : henry
|
|
47
|
+ - **frontend (review)** : donuts, richard
|
|
48
|
+ - **localization** : henry, pierov
|
|
49
|
+ - **nightly builds** : boklm
|
|
50
|
+ - **rebases/release-prep** : dan_b, ma1, pierov, richard
|
|
51
|
+ - **security** : ma1
|
|
52
|
+ - **signing** : boklm, richard
|
|
53
|
+ - **updater** : pierov
|
|
54
|
+ - **misc/other** : pierov, richard
|
|
55
|
+
|
|
56
|
+#### Change Description
|
|
57
|
+
|
|
58
|
+<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour --> |