[tor-commits] [tor/master] Add a couple more cases to reach 100% coverage.

[nickm@xxxxxxxxxxxxxx]

commit d6594bfa8c56a6a6896c8ca8761e39f0c3dd59a2
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Tue Mar 7 12:30:13 2017 -0500

    Add a couple more cases to reach 100% coverage.
---
 src/test/test_consdiff.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/src/test/test_consdiff.c b/src/test/test_consdiff.c
index b511d94..bbe3532 100644
--- a/src/test/test_consdiff.c
+++ b/src/test/test_consdiff.c
@@ -449,6 +449,25 @@ test_consdiff_gen_ed_diff(void *arg)
          "because the target consensus doesn't have its router entries sorted "
          "properly.");
 
+  /* Same as the two above, but with the reversed thing immediately after a
+     match. (The code handles this differently) */
+  smartlist_del(cons1, 0);
+  smartlist_add(cons1, (char*)"r name aaaaaaaaaaaaaaaaaaaaaaaaaaa etc");
+
+  mock_clean_saved_logs();
+  diff = gen_ed_diff(cons1, cons2);
+  tt_ptr_op(NULL, OP_EQ, diff);
+  expect_single_log_msg_containing("Refusing to generate consensus diff "
+         "because the base consensus doesn't have its router entries sorted "
+         "properly.");
+
+  mock_clean_saved_logs();
+  diff = gen_ed_diff(cons2, cons1);
+  tt_ptr_op(NULL, OP_EQ, diff);
+  expect_single_log_msg_containing("Refusing to generate consensus diff "
+         "because the target consensus doesn't have its router entries sorted "
+         "properly.");
+
   /* Identity hashes are repeated, return NULL. */
   smartlist_clear(cons1);
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits