[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/mullvad-browser][mullvad-browser-128.8.0esr-14.5-1] 4 commits: Bug 1917556 - [marionette] Fix Mn tests with Python 3.12 r=webdriver-reviewers,whimboo

Title: GitLab

Pier Angelo Vendrame pushed to branch mullvad-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser

Commits:

  • 9492cb87
    by Julian Descottes at 2025-03-06T10:46:29+01:00 
    Bug 1917556 - [marionette] Fix Mn tests with Python 3.12 r=webdriver-reviewers,whimboo

Differential Revision: https://phabricator.services.mozilla.com/D221448
  • 29861015
    by Beatriz Rizental at 2025-03-06T10:47:06+01:00 
    fixup! Base Browser's .mozconfigs.
  • 63d64ecc
    by Beatriz Rizental at 2025-03-06T10:47:15+01:00 
    BB 43535: Enable tests
  • 2aa78353
    by John Lin at 2025-03-10T14:20:42+00:00 
    Bug 1924070 - modify H.264 extradata to match sample conversion code. r=media-playback-reviewers,alwu

In AVC stream, NAL unit is represented with the length of unit data
(NALUnitLength) followed by the actual unit data(NALUnit). The NALUnitLength
field can be 1-4 bytes long and the size can be derived from the
'lengthSizeMinusOne' value recorded in extradata.
H264ChangeMonitor.CheckForChange() reformats all input samples so that
NALUnitLength will always be 4 bytes long while the original extradata is
used during decoder creation earlier, so decoder won't be able to correctly
parse converted samples if extradata is not modified accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D239547

6 changed files:

Changes:

  • dom/media/platforms/wrappers/MediaChangeMonitor.cpp
    ... ... @@ -42,6 +42,14 @@ class H264ChangeMonitor : public MediaChangeMonitor::CodecChangeMonitor {
    42 42 
           : mCurrentConfig(aInfo), mFullParsing(aFullParsing) {
    43 43 
         if (CanBeInstantiated()) {
    44 44 
           UpdateConfigFromExtraData(aInfo.mExtraData);
    45 
    +      auto avcc = AVCCConfig::Parse(mCurrentConfig.mExtraData);
    46 
    +      if (avcc.isOk() && avcc.unwrap().NALUSize() != 4) {
    47 
    +        // `CheckForChange()` will use `AnnexB::ConvertSampleToAVCC()` to change
    48 
    +        // NAL units into 4-byte.
    49 
    +        // `AVCDecoderConfigurationRecord.lengthSizeMinusOne` in the config
    50 
    +        // should be modified too.
    51 
    +        mCurrentConfig.mExtraData->ReplaceElementAt(4, 0xfc | 3);
    52 
    +      }
    45 53 
         }
    46 54 
       }
    47 55

  • mozconfig-linux-aarch64-dev
    ... ... @@ -16,3 +16,5 @@ ac_add_options --disable-install-strip
    16 16
    17 17 
     ac_add_options --with-base-browser-version=dev-build
    18 18 
     ac_add_options --disable-base-browser-update
    19 
    +
    20 
    +ac_add_options --enable-tests

  • mozconfig-linux-x86_64-dev
    ... ... @@ -19,3 +19,5 @@ ac_add_options --disable-base-browser-update
    19 19
    20 20 
     # Let's make sure no preference is enabling either Adobe's or Google's CDM.
    21 21 
     ac_add_options --disable-eme
    22 
    +
    23 
    +ac_add_options --enable-tests

  • mozconfig-macos-dev
    ... ... @@ -19,3 +19,5 @@ ac_add_options --disable-update-agent
    19 19
    20 20 
     # Let's make sure no preference is enabling either Adobe's or Google's CDM.
    21 21 
     ac_add_options --disable-eme
    22 
    +
    23 
    +ac_add_options --enable-tests

  • testing/marionette/harness/marionette_harness/runner/base.py
    ... ... @@ -222,7 +222,7 @@ class MarionetteTestResult(StructuredTestResult, TestResultCollection):
    222 222 
                     self.logger.info("END LOG:")
    223 223
    224 224 
         def stopTest(self, *args, **kwargs):
    225 
    -        unittest._TextTestResult.stopTest(self, *args, **kwargs)
    225 
    +        unittest.TextTestResult.stopTest(self, *args, **kwargs)
    226 226 
             if self.marionette.check_for_crash():
    227 227 
                 # this tells unittest.TestSuite not to continue running tests
    228 228 
                 self.shouldStop = True

  • testing/specialpowers/api.js
    ... ... @@ -40,6 +40,18 @@ this.specialpowers = class extends ExtensionAPI {
    40 40 
             uri,
    41 41 
             resProto.ALLOW_CONTENT_ACCESS
    42 42 
           );
    43 
    +    } else {
    44 
    +      // This is a hack!
    45 
    +      // For some reason, this specific substituion has an extra `/` in the path.
    46 
    +      // This is a workaround to fix it.
    47 
    +      //
    48 
    +      // TODO (#43545): Remove this once we have a proper fix.
    49 
    +      let uri = resProto.getSubstitution("testing-common");
    50 
    +      resProto.setSubstitution(
    51 
    +        "testing-common",
    52 
    +        Services.io.newURI(uri.spec.replace("file:////", "file:///")),
    53 
    +        resProto.ALLOW_CONTENT_ACCESS
    54 
    +      );
    43 55 
         }
    44 56
    45 57 
         SpecialPowersParent.registerActor();

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx