[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-132.0a1-15.0-2] 251 commits: Bug 1935621 - Fix virtual environment sysconfig path calculation...

Pier Angelo Vendrame pushed to branch tor-browser-132.0a1-15.0-2 at The Tor Project / Applications / Tor Browser

Commits:

76e973ea

by Filipe Laíns at 2025-03-13T09:15:58+01:00

Bug 1935621 - Fix virtual environment sysconfig path calculation r=firefox-build-system-reviewers,ahochheiden

Signed-off-by: Filipe Laíns <lains@xxxxxxxxxx>

Signed-off-by: Filipe Laíns <lains@xxxxxxxxxx>

Signed-off-by: Filipe Laíns <lains@xxxxxxxxxx>

Differential Revision: https://phabricator.services.mozilla.com/D231480

267cc95c

by Mike Hommey at 2025-03-13T09:15:59+01:00

Bug 1906851 - Use mozbuild.shellutil.quote instead of pipes.quote.  a=RyanVM

The latter was removed in python 3.13, and while it can be replaced with
shlex, we also have our own version that considers more characters as
needing quotes.

Original Revision: https://phabricator.services.mozilla.com/D225329

Differential Revision: https://phabricator.services.mozilla.com/D225608

49c28377

by Henry Wilkes at 2025-03-13T09:15:59+01:00

BB 41454: Move focus after calling openPreferences for a sub-category.

Temporary fix until mozilla bug 1799153 gets a patch upstream.

006f8e6d

by Henry Wilkes at 2025-03-13T09:15:59+01:00

BB 43072: Add aria label and description to moz-message-bar.

Ensures that moz-message-bar, including notifications, are announced on
Orca.

This addresses upstream bugzilla bug 1895857 and should likely be
replaced when it is fixed.

4ae55604

by Henry Wilkes at 2025-03-13T09:15:59+01:00

BB 42739: Use the brand name for profile error messages.

Some messages in profileSelection.properties use gAppData->name as
variable inputs. However, gAppData->name is still "Firefox" for our
base-browser builds, rather than the user-facing browser name. We swap
these instances with the displayed brand name instead.

d840c486

by hackademix at 2025-03-13T09:16:00+01:00

BB 42194: Fix blank net error page on failed DNS resolution with active proxy.

4c72f478

by Henry Wilkes at 2025-03-13T09:16:00+01:00

BB 41483: Remove the firefox override for appstrings.properties

Remove this patch after upstream bugzilla bug 1790187

ebea20b6

by hackademix at 2025-03-13T09:16:00+01:00

BB 43101: Deep link to the startup security warning explanation.

12617b80

by Marco Simonelli at 2025-03-13T09:16:00+01:00

BB 41459: WebRTC fails to build under mingw (Part 1)

- properly define NOMINMAX for just MSVC builds

a0524bf3

by Marco Simonelli at 2025-03-13T09:16:00+01:00

BB 41459: WebRTC fails to build under mingw (Part 2)

- fixes required to build third_party/libwebrtc

bd0f83d0

by Marco Simonelli at 2025-03-13T09:16:01+01:00

BB 41459: WebRTC fails to build under mingw (Part 3)

- fixes required to build third_party/sipcc

440a02d5

by Marco Simonelli at 2025-03-13T09:16:01+01:00

BB 41459: WebRTC fails to build under mingw (Part 4)

- fixes requried to build netwerk/sctp

ac0c8761

by Marco Simonelli at 2025-03-13T09:16:01+01:00

BB 41459: WebRTC fails to build under mingw (Part 5)

- fixes required to build dom/media/webrtc

634ae5f6

by Marco Simonelli at 2025-03-13T09:16:01+01:00

BB 41459: WebRTC fails to build under mingw (Part 6)

- fixes required to build dom/media/systemservices

df816367
by june wilde at 2025-03-13T09:16:02+01:00
```
BB 42758: Fix WebRTC build errors.
```

044477e9

by hackademix at 2025-03-13T09:16:02+01:00

BB 41854: Allow overriding download spam protection.

205ce346

by hackademix at 2025-03-13T09:16:02+01:00

BB 42832: Download spam prevention exemption for browser extensions.

4dc498ee

by Pier Angelo Vendrame at 2025-03-13T09:16:02+01:00

BB 42220: Allow for more file types to be forced-inline.

Firefox allows to open some files in the browser without any
confirmation, but this will result in a disk leak, because the file will
be downloaded to the temporary directory first (and not deleted, in some
cases).
A preference allows PDFs to be opened without being downloaded to disk.
So, we introduce a similar one to do the same for all the files that are
set to be opened automatically in the browser.

9ee9919d

by hackademix at 2025-03-13T09:16:03+01:00

BB 42835: Create an actor to filter file data transfers

82f9e759
by Beatriz Rizental at 2025-03-13T09:16:03+01:00
```
BB 42728: Modify ./mach lint to skip unused linters
```
20f7f64f
by Gaba at 2025-03-13T09:16:03+01:00
```
Adding issue and merge request templates
```

c0d37999

by Morgan at 2025-03-13T09:18:59+01:00

fixup! Adding issue and merge request templates

add issue template for mozilla uplifts and tweak MR template to signal to merger an uplift issue should be created after merge

25048fa0

by Morgan at 2025-03-13T09:19:00+01:00

fixup! Adding issue and merge request templates

add backport template and tweak the uplift template

76faa74c

by Morgan at 2025-03-13T09:19:00+01:00

fixup! Adding issue and merge request templates

include Bugzilla as potential source of backports

d4fb33c5

by Morgan at 2025-03-13T09:19:00+01:00

fixup! Adding issue and merge request templates

update the auto /label command to Apps::Type::Bug

7f37cc64

by Morgan at 2025-03-13T09:19:00+01:00

fixup! Adding issue and merge request templates

update release prep label link

c429a49c

by hackademix at 2025-03-13T09:19:01+01:00

fixup! Adding issue and merge request templates

TBB 41382: Replace gitlab templates ReleasePrep label references with Apps::Type::ReleasePreparation

194dd244

by Richard Pospesel at 2025-03-13T09:19:01+01:00

BB 42683: Create script to generate issue triage csv file from bugzilla query and git logs

4874e52f

by Henry Wilkes at 2025-03-13T09:19:01+01:00

BB 42305: Add script to combine translation files across versions.

b679e664

by Henry Wilkes at 2025-03-13T09:19:01+01:00

fixup! BB 42305: Add script to combine translation files across versions.

TB 43446: Allow the combine translation script to select some branding
strings from different files.

b9f06416
by Beatriz Rizental at 2025-03-13T09:19:02+01:00
```
Add CI for Base Browser
```

331ac27b

by Pier Angelo Vendrame at 2025-03-13T09:19:02+01:00

Base Browser's .mozconfigs.

Bug 17858: Cannot create incremental MARs for hardened builds.
Define HOST_CFLAGS, etc. to avoid compiling programs such as mbsdiff
(which is part of mar-tools and is not distributed to end-users) with
ASan.

Bug 21849: Don't allow SSL key logging.

Bug 25741 - TBA: Disable features at compile-time

Define MOZ_ANDROID_NETWORK_STATE and MOZ_ANDROID_LOCATION

Bug 27623 - Export MOZILLA_OFFICIAL during desktop builds

This fixes a problem where some preferences had the wrong default value.
Also see bug 27472 where we made a similar fix for Android.

Bug 29859: Disable HLS support for now

Bug 30463: Explicitly disable MOZ_TELEMETRY_REPORTING

Bug 32493: Disable MOZ_SERVICES_HEALTHREPORT

Bug 33734: Set MOZ_NORMANDY to False

Bug 33851: Omit Parental Controls.

Bug 40252: Add --enable-rust-simd to our tor-browser mozconfig files

Bug 41584: Move some configuration options to base-browser level

c3654582

by Pier Angelo Vendrame at 2025-03-13T09:19:02+01:00

Tweaks to the build system

Bug 40857: Modified the fat .aar creation file

This is a workaround to build fat .aars with the compiling enviornment
disabled.
Mozilla does not use a similar configuration, but either runs a Firefox
build and discards its output, or uses artifacts build.

We might switch to artifact builds too, and drop this patch, or write a
better one to upstream. But until then we need this patch.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1763770.

Bug 41458: Prevent `mach package-multi-locale` from actually creating a package

macOS builds need some files to be moved around with
./mach package-multi-locale to create multi-locale packages.
The required command isn't exposed through any other mach command.
So, we patch package-multi-locale both to prevent it from failing when
doing official builds and to detect any future changes on it.

a276babc
by Pier Angelo Vendrame at 2025-03-13T09:19:02+01:00
```
BB 29320: Replace the gnu target with gnullvm for Rust.
```

c111614e

by Pier Angelo Vendrame at 2025-03-13T09:19:02+01:00

BB 42616: Remove VideoCaptureTest.kt.

This is a workaround to fix the GeckoView build with WebRTC disabled.
We should replace this workaround with a proper solution, that
excludes this test when MOZ_WEBRTC is undefined/False.

88e67592
by Pier Angelo Vendrame at 2025-03-13T09:19:03+01:00
```
BB 41108: Remove privileged macOS installation from 102
```

075bfd79

by Dan Ballard at 2025-03-13T09:19:03+01:00

BB 41149: Re-enable DLL injection protection in all builds not just nightlies

58386729

by Henry Wilkes at 2025-03-13T09:19:03+01:00

BB 43092: Disable wayland by default in Base Browser.

f4f98ea3

by Matthew Finkel at 2025-03-13T09:19:03+01:00

BB 24796: Comment out excess permissions from GeckoView

The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
manifest, so we can't use the ifdef preprocessor guards around the
permissions we do not want. Commenting the permissions is the
next-best-thing.

894aff5e
by Matthew Finkel at 2025-03-13T09:19:04+01:00
```
BB 28125: Prevent non-Necko network connections
```

187ee330

by Mike Perry at 2025-03-13T09:19:04+01:00

BB 12974: Disable NTLM and Negotiate HTTP Auth

The Mozilla bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1046421,
https://bugzilla.mozilla.org/show_bug.cgi?id=1261591, tor-browser#27602

0229d027
by cypherpunks1 at 2025-03-13T09:19:04+01:00
```
BB 40717: Hide Windows SSO in settings
```

a46fb9f5

by Georg Koppen at 2025-03-13T09:19:04+01:00

BB 16285: Exclude ClearKey system for now

In the past the ClearKey system had not been compiled when specifying
--disable-eme. But that changed and it is even bundled nowadays (see:
Mozilla's bug 1300654). We don't want to ship it right now as the use
case for it is not really visible while the code had security
vulnerabilities in the past.

4c9f01e1

by Kathy Brade at 2025-03-13T09:19:05+01:00

BB 21431: Clean-up system extensions shipped in Firefox

Only ship the pdfjs extension.

582ca28e
by Henry Wilkes at 2025-03-13T09:19:05+01:00
```
BB 42831: Remove the shopping components.
```

99781615

by Kathy Brade at 2025-03-13T09:19:05+01:00

BB 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc.

Hide elements on about:logins that mention sync, "Firefox LockWise", and
Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.

37a3ec65

by Alex Catarineu at 2025-03-13T09:19:05+01:00

BB 41457: Remove Mozilla permissions

Bug 40025: Remove Mozilla add-on install permissions

bdc4b099

by Kathy Brade at 2025-03-13T09:19:05+01:00

Bug 41662: Disable about:sync-logs

Even though we disable sync by default with
`identity.fxaccounts.enabled`, this about: page is still avilable.
We could throw an exception on the constructor of the related
component, but it would result only in an error in the console, without
a visible "this address does not look right" error page.
If we fix the issues with MOZ_SERVICES_SYNC, we can restore the
component.

d5b07260
by Morgan at 2025-03-13T09:19:06+01:00
```
BB 42716: Disable unwanted about: pages
```

f5972dbf

by Henry Wilkes at 2025-03-13T09:19:06+01:00

fixup! BB 42716: Disable unwanted about: pages

TB 43308: Remove about:logo which exposes a branding asset.

c33dd694

by Arthur Edelstein at 2025-03-13T09:19:06+01:00

BB 26353: Prevent speculative connect that violated FPI.

Connections were observed in the catch-all circuit when
the user entered an https or http URL in the URL bar, or
typed a search term.

b41f62ad

by Alex Catarineu at 2025-03-13T09:19:06+01:00

BB 31740: Remove some unnecessary RemoteSettings instances

More concretely, SearchService.jsm 'hijack-blocklists' and
url-classifier-skip-urls.

Avoid creating instance for 'anti-tracking-url-decoration'.

If prefs are disabling their usage, avoid creating instances for
'cert-revocations' and 'intermediates'.

Do not ship JSON dumps for collections we do not expect to need. For
the ones in the 'main' bucket, this prevents them from being synced
unnecessarily (the code in remote-settings does so for collections
in the main bucket for which a dump or local data exists). For the
collections in the other buckets, we just save some size by not
shipping their dumps.

We also clear the collections database on the v2 -> v3 migration.

f6649b34

by cypherpunks1 at 2025-03-13T09:19:07+01:00

BB 41092: Add a RemoteSettings JSON dump for query-stripping

071c925f

by cypherpunks1 at 2025-03-13T09:19:07+01:00

BB 42730: Patch RemoteSettings to use only local dumps as a data source

c8a7b6c8

by Pier Angelo Vendrame at 2025-03-13T09:19:07+01:00

BB 41635: Disable the Normandy component

Do not include Normandy at all whenever MOZ_NORMANDY is False.

9fc0ea5f

by Georg Koppen at 2025-03-13T09:19:07+01:00

BB 30541: Disable WebGL readPixel() for web content

Related Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1428034

0541ec9b
by Alex Catarineu at 2025-03-13T09:19:08+01:00
```
BB 28369: Stop shipping pingsender executable
```
10e50e57
by Henry Wilkes at 2025-03-13T09:19:08+01:00
```
BB 42630: Disable LaterRun module.
```

01c47a89

by Pier Angelo Vendrame at 2025-03-13T09:19:08+01:00

BB 41599: Always return an empty string as network ID

Firefox computes an internal network ID used to detect network changes
and act consequently (e.g., to improve WebSocket UX).
However, there are a few ways to get this internal network ID, so we
patch them out, to be sure any new code will not be able to use them and
possibly link users.

We also sent a patch to Mozilla to seed the internal network ID, to
prevent any accidental leak in the future.
Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1817756

7bcc44ee

by Pier Angelo Vendrame at 2025-03-13T09:19:08+01:00

BB 43386: Use Firefox in the UA in RFP-exempt request.

XHR requests initiated by extensions are exempt from RFP.
Therefore, they report the actual app name, instead of Firefox, and the
actual Firefox minor version.

This happens whenever the app name has been customized and does not
match a hardcoded "Firefox".

e693af46
by Richard Pospesel at 2025-03-13T09:19:09+01:00
```
BB 41327: Disable UrlbarProviderInterventions
```
7e8df76e
by Richard Pospesel at 2025-03-13T09:19:09+01:00
```
BB 42037: Disable about:firefoxview page
```
b533469f
by Mike Perry at 2025-03-13T09:19:09+01:00
```
Firefox preference overrides.
```

7864c8fe

by Pier Angelo Vendrame at 2025-03-13T09:19:09+01:00

BB 43140: Tighten up fonts on Linux.

We ship a fontconfig configuration to esnure all Linux users have the
same defaults and reduce the chances of fingerprinting.
We used to add this file in tor-browser-build, but some users might
skip it by using the browser executable without the wrapper script.
Therefore, we decided to activate the file with the FontConfig API
instead of the environment variables.

Bug 41043: Hardcode the UI font on Linux

The mechanism to choose the UI font does not play well with our
fontconfig configuration. As a result, the final criterion to choose
the font for the UI was its version.

Since we hardcode Arimo as a default sans-serif on preferences, we use
it also for the UI. FontConfig will fall back to some other font for
scripts Arimo does not cover as expected (we tested with Japanese).

Bug 43141: Hardcode system-ui to Arimo.

e8f5a4d8

by Pier Angelo Vendrame at 2025-03-13T09:19:09+01:00

BB 41901: Hardcode normalized FontSubstitutes.

Windows has a system to set font aliases through the registry.
This allows some customization that could be used as a fingerprinting
vector.
Moreover, this mechanism is used by Windows itself, and different SKUs
might have different default FontSubstitutes.

7543ae29

by Pier Angelo Vendrame at 2025-03-13T09:19:10+01:00

BB 43322: Customize the font visibility lists.

Customize the lists of fonts to assign base visibility to in
base browser and derivatives.

Also, rename the files with the upstream lists, to make sure we do not
use them by mistake.

8e973eab

by Alex Catarineu at 2025-03-13T09:19:10+01:00

BB 30605: Honor privacy.spoof_english in Android

This checks `privacy.spoof_english` whenever `setLocales` is
called from Fenix side and sets `intl.accept_languages`
accordingly.

Bug 40198: Expose privacy.spoof_english pref in GeckoView

28529102

by Pier Angelo Vendrame at 2025-03-13T09:19:10+01:00

BB 42562: Normalized the Accepted Languages on Android.

The OS language might be outside the list of actually supported
languages and it might leak the user's region.
Therefore, we force the locale reported in Accept-Language to match one
we support with translations, even when it means using a not exact
region tag.

60c254d7

by Alex Catarineu at 2025-03-13T09:19:10+01:00

BB 40171: Make WebRequest and GeckoWebExecutor First-Party aware

859bdf3a
by Alex Catarineu at 2025-03-13T09:19:11+01:00
```
BB 26345: Hide tracking protection UI
```

d0afeb7d

by Henry Wilkes at 2025-03-13T09:19:11+01:00

BB 43109: Hide Firefox Relay from settings.

This should remain disabled, see tor-browser#42814.

f3f36a3e

by Henry Wilkes at 2025-03-13T09:19:11+01:00

BB 42777: Hide Website Privacy Preferences.

We hide the Website Privacy Preferences section, which controls the
"global privacy control" (GPC) and "do not track" (DNT) settings.

cbee546b

by Morgan at 2025-03-13T09:19:11+01:00

BB 42070: Hide "Use smooth scrolling" from settings

2694a513

by Arthur Edelstein at 2025-03-13T09:19:12+01:00

BB 18905: Hide unwanted items from help menu

Bug 25660: Remove the "New Private Window" option

3d207a13

by Pier Angelo Vendrame at 2025-03-13T09:19:12+01:00

BB 41739: Remove "Website appearance" from about:preferences.

It is ignored because of RFP and it is confusing for users.

73147b05

by Henry Wilkes at 2025-03-13T09:19:12+01:00

BB 43117: Hide "Always underline links" from settings.

e45a5a81
by Pier Angelo Vendrame at 2025-03-13T09:19:12+01:00
```
BB 42774: Always hide the third-pary certs UI.
```

136041c4

by Henry Wilkes at 2025-03-13T09:19:13+01:00

BB 43118: Hide feature recommendation (CFR) settings.

1b2ed9f8

by Pier Angelo Vendrame at 2025-03-13T09:19:13+01:00

BB 9173: Change the default Firefox profile directory to be relative.

This commit makes Firefox look for the default profile directory in a
directory relative to the binary path.
The directory can be specified through the --with-relative-data-dir.
This is relative to the same directory as the firefox main binary for
Linux and Windows.

On macOS, we remove Contents/MacOS from it.
Or, in other words, the directory is relative to the application
bundle.

This behavior can be overriden at runtime, by placing a file called
system-install adjacent to the firefox main binary (also on macOS).

3b4b4276

by Pier Angelo Vendrame at 2025-03-13T09:19:13+01:00

BB 42773: Replace ~ with the original home.

In Bug 93141, Mozilla started sending users to their home when they type
~ in the URL bar.
On Linux, we change $HOME for various reason, therefore you would be
redirected to the spoofed home directory when typing ~.
So, we check if the original home directory is known, and use that,
instead.

8c86e73a

by Alex Catarineu at 2025-03-13T09:19:13+01:00

BB 27604: Fix addon issues when moving the profile directory

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1429838

d2cf32b4

by Mike Perry at 2025-03-13T09:19:13+01:00

BB 13028: Prevent potential proxy bypass cases.

It looks like these cases should only be invoked in the NSS command line
tools, and not the browser, but I decided to patch them anyway because there
literally is a maze of network function pointers being passed around, and it's
very hard to tell if some random code might not pass in the proper proxied
versions of the networking code here by accident.

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1433509

e862e5c1

by Pier Angelo Vendrame at 2025-03-13T09:19:14+01:00

BB 40309: Avoid using regional OS locales

Avoid regional OS locales if the pref
`intl.regional_prefs.use_os_locales` is false but RFP is enabled.

3f165877

by Matthew Finkel at 2025-03-13T09:19:14+01:00

BB 40432: Prevent probing installed applications

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1711084

f80a4d54

by cypherpunks1 at 2025-03-13T09:19:14+01:00

BB 33955: When copying an image only copy the image contents to the clipboard

82319c91

by cypherpunks1 at 2025-03-13T09:19:14+01:00

BB 41791: Omit the source URL when copying page contents to the clipboard

0cabdcae

by hackademix at 2025-03-13T09:19:15+01:00

BB 42288: Allow language spoofing in status messages.

b23618b9

by Pier Angelo Vendrame at 2025-03-13T09:19:15+01:00

BB 43196: Remove the vendor name from media notifications on Linux.

Firefox shows "vendor remoteName" as a title of the "... is playing
media" notification on Linux.
However, for our browser the remote name is enough, and prepending the
vendor to it creates a string users usually never see.

0b93f6d1

by Pier Angelo Vendrame at 2025-03-13T09:19:15+01:00

Base Browser strings

This commit adds all the strings needed by following Base Browser
patches.

055150de

by Henry Wilkes at 2025-03-13T09:19:15+01:00

BB 42583: Modify moz-support-link for Base Browser.

223358fa

by Pier Angelo Vendrame at 2025-03-13T09:19:16+01:00

BB 41369: Improve Firefox language settings for multi-lingual packages

Change the language selector to be sorted by language code, rather than
name, and to display the language code to the user.

Bug 41372: Handle Japanese as a special case in preferences on macOS

Japanese is treated in a special way on macOS. However, seeing the
Japanese language tag could be confusing for users, and moreover the
language name is not localized correctly like other langs.

Bug 41378: Tell users that they can change their language at the first start

With multi-lingual builds, Tor Browser matches the user's system
language, but some users might want to change it.
So, we tell them that it is possible, but only once.

05419656

by p13dz at 2025-03-13T09:19:16+01:00

BB 40283: Workaround for the file upload bug

b194eda3

by hackademix at 2025-03-13T09:19:16+01:00

BB 42019: Empty browser's clipboard on browser shutdown

750a1897

by hackademix at 2025-03-13T09:19:16+01:00

BB 42084: Ensure English spoofing works even if preferences are set out of order.

3532da9c
by Pier Angelo Vendrame at 2025-03-13T09:19:16+01:00
```
BB 41930: Remove the UI to customize accept_languages.
```
28f65a1b
by hackademix at 2025-03-13T09:19:17+01:00
```
BB 41434: Letterboxing, improve logging.
```

e0174977

by hackademix at 2025-03-13T09:19:17+01:00

BB 41434: Letterboxing, preemptively apply margins in a global CSS rule to mitigate race conditions on newly created windows and tabs.

4870247d

by hackademix at 2025-03-13T09:19:17+01:00

BB 31064: Letterboxing, exempt browser extensions.

115f8136

by hackademix at 2025-03-13T09:19:17+01:00

BB 32411: Letterboxing, exempt view-source: URIs.

facbb12e
by hackademix at 2025-03-13T09:19:18+01:00
```
BB 42574: Letterboxing, exempt pdf.js.
```

2516af8f

by hackademix at 2025-03-13T09:19:18+01:00

BB 32308: Use direct browser sizing for letterboxing.

Bug 30556: align letterboxing with 200x100 new win width stepping

d29d760a

by Pier Angelo Vendrame at 2025-03-13T09:19:18+01:00

fixup! BB 32308: Use direct browser sizing for letterboxing.

When the dimension is less than 50px, we need to return dimension
itself, rather than a 0px margin.

a60872e8

by hackademix at 2025-03-13T09:19:18+01:00

BB 41631: Prevent weird initial window dimensions caused by subpixel computations

0316b7c8

by Pier Angelo Vendrame at 2025-03-13T09:30:25+01:00

fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations

BB 43205: Fix newwin rounding.

RFP might produce bad rounding because of platform-specific bugs.
Solving them might involve a refactor that is out of our capacity,
therefore we add a JS patch to fix wrong sizes.

534294c4

by hackademix at 2025-03-13T09:31:35+01:00

BB 41918: Option to reuse last window size when letterboxing is enabled.

4b74ac5e

by Pier Angelo Vendrame at 2025-03-13T09:31:35+01:00

fixup! BB 41918: Option to reuse last window size when letterboxing is enabled.

BB 43205: Fix newwin rounding.

Do not fix sizes when remember last size is enabled.

2ab79a83
by hackademix at 2025-03-13T09:31:36+01:00
```
BB 41916: Letterboxing preferences UI
```

26ffc83e

by hackademix at 2025-03-13T09:31:36+01:00

BB 41695: Warn on window maximization without letterboxing in RFPHelper module

a49319df

by hackademix at 2025-03-13T09:31:36+01:00

BB 42443: Shrink window to match letterboxing size when the emtpy area is clicked.

aa1fe6c8

by Henry Wilkes at 2025-03-13T09:31:36+01:00

BB 42528: Don't leak system scrollbar size on windows.

9c5dd14b

by Henry Wilkes at 2025-03-13T09:31:36+01:00

BB 31575: Disable Firefox Home (Activity Stream)

Treat about:blank as the default home page and new tab page.

Avoid loading AboutNewTab in BrowserGlue.sys.mjs in order
to avoid several network requests that we do not need.

Bug 41624: Disable about:pocket-* pages.

Bug 40144: Redirect about:privatebrowsing to the user's home

98238362

by Kathy Brade at 2025-03-13T09:31:37+01:00

BB 4234: Use the Firefox Update Process for Base Browser.

Windows: disable "runas" code path in updater (15201).
Windows: avoid writing to the registry (16236).
Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
  16014, 16909, 24476, and 25909.

Also fix bug 27221: purge the startup cache if the Base Browser
version changed (even if the Firefox version and build ID did
not change), e.g., after a minor Base Browser update.

Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.

Bug 26048: potentially confusing "restart to update" message

Within the update doorhanger, remove the misleading message that mentions
that windows will be restored after an update is applied, and replace the
"Restart and Restore" button label with an existing
"Restart to update Tor Browser" string.

Bug 28885: notify users that update is downloading

Add a "Downloading Base Browser update" item which appears in the
hamburger (app) menu while the update service is downloading a MAR
file. Before this change, the browser did not indicate to the user
that an update was in progress, which is especially confusing in
Tor Browser because downloads often take some time. If the user
clicks on the new menu item, the about dialog is opened to allow
the user to see download progress.

As part of this fix, the update service was changed to always show
update-related messages in the hamburger menu, even if the update
was started in the foreground via the about dialog or via the
"Check for Tor Browser Update" toolbar menu item. This change is
consistent with the Tor Browser goal of making sure users are
informed about the update process.

Removed #28885 parts of this patch which have been uplifted to Firefox.

c7f98925
by Pier Angelo Vendrame at 2025-03-13T09:31:37+01:00
```
BB 42061: Create an alpha update channel.
```
9bb771d9
by Nicolas Vigier at 2025-03-13T09:31:37+01:00
```
BB 41682: Add base-browser nightly mar signing key
```

3e451854

by Pier Angelo Vendrame at 2025-03-13T09:31:37+01:00

BB 41603: Customize the creation of MOZ_SOURCE_URL

MOZ_SOURCE_URL is created by combining MOZ_SOURCE_REPO and
MOZ_SOURCE_CHANGESET.
But the code takes for granted that it refers to a Hg instance, so it
combines them as `$MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET`.
With this commit, we change this logic to combine them to create a URL
that is valid for GitLab.
$MOZ_SOURCE_CHANGESET needs to be a commit hash, not a branch or a tag.
If that is needed, we could use /-/tree/, instead of /-/commit/.

88c09e1b

by Pier Angelo Vendrame at 2025-03-13T09:31:38+01:00

BB 41698: Reword the recommendation badges in about:addons

Firefox strings use { -brand-product-name }.
As a result, it seems that the fork is recommending extensions, whereas
AMO curators are doing that.
So, we replace the strings with custom ones that clarify that Mozilla is
recommending them.

We assign the strings with JS because our translation backend does not
support Fluent attributes, yet, but once it does, we should switch to
them, instead.

Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1825033

d47c350e

by Pier Angelo Vendrame at 2025-03-13T09:31:38+01:00

BB 42438: Tweaks to the migration wizard.

Remove the items not compatible with our features (such as history) from
the migration wizard.

On Linux, allow to specify an alternative home directory, since we
usually change $HOME in our startup script.

a32e37d6

by Alex Catarineu at 2025-03-13T09:31:38+01:00

BB 40069: Add helpers for message passing with extensions

5294084e

by Matthew Finkel at 2025-03-13T09:31:38+01:00

BB 41598: Prevent NoScript from being removed/disabled.

Bug 40253: Explicitly allow NoScript in Private Browsing mode.

c163400f

by Henry Wilkes at 2025-03-13T09:31:39+01:00

BB 41581: Hide NoScript extension's toolbar button by default.

This hides it from both the toolbar and the unified extensions panel.

We also hide the unified-extension-button if the panel would be empty:
not including the NoScript button when it is hidden. As a result, this
will be hidden by default until a user installs another extension (or
shows the NoScript button and unpins it).

c7abb133

by hackademix at 2025-03-13T09:31:39+01:00

BB 41834: Hide "Can't Be Removed - learn more" menu line for uninstallable add-ons

59187191

by Pier Angelo Vendrame at 2025-03-13T09:31:39+01:00

BB 40925: Implemented the Security Level component

This component adds a new Security Level toolbar button which visually
indicates the current global security level via icon (as defined by the
extensions.torbutton.security_slider pref), a drop-down hanger with a
short description of the current security level, and a new section in
the about:preferences#privacy page where users can change their current
security level. In addition, the hanger and the preferences page will
show a visual warning when the user has modified prefs associated with
the security level and provide a one-click 'Restore Defaults' button to
get the user back on recommended settings.

Bug 40125: Expose Security Level pref in GeckoView

7329eff7

by Pier Angelo Vendrame at 2025-03-13T09:31:39+01:00

fixup! BB 40925: Implemented the Security Level component

BB 43498: Remove our old patch for 43129.

This commit should be ignored at the next rebase (and we will likely
have a conflict on the security level commit).

57864ec2
by Pier Angelo Vendrame at 2025-03-13T09:31:44+01:00
```
BB 40926: Implemented the New Identity feature
```
d6e89913
by Henry Wilkes at 2025-03-13T09:31:44+01:00
```
BB 41736: Customize toolbar for base-browser.
```

741aeea0

by Pier Angelo Vendrame at 2025-03-13T09:31:44+01:00

BB 42027: Base Browser migration procedures.

This commit implmenents the the Base Browser's version of _migrateUI.

ffa27c1e

by Henry Wilkes at 2025-03-13T09:31:44+01:00

TB 42308: Create README for tor-browser.

We drop the README.txt that comes from Mozilla Firefox and add README.md
for tor-browser.

7878f45b

by Richard Pospesel at 2025-03-13T09:31:45+01:00

TB 41649: Create rebase and security backport gitlab issue templates

ffc19db6

by Morgan at 2025-03-13T09:31:45+01:00

fixup! TB 41649: Create rebase and security backport gitlab issue templates

add base-browser branch+taggging step

82d3b385

by Morgan at 2025-03-13T09:31:45+01:00

fixup! TB 41649: Create rebase and security backport gitlab issue templates

add /label command to add Apps::Type::Rebase automatically

5f2975e1

by hackademix at 2025-03-13T09:31:45+01:00

fixup! TB 41649: Create rebase and security backport gitlab issue templates

TBB 41382: Replace gitlab templates ReleasePrep label references with Apps::Type::ReleasePreparation

f9ac038a
by Beatriz Rizental at 2025-03-13T09:31:46+01:00
```
Add CI for Tor Browser
```

0a142531

by Henry Wilkes at 2025-03-13T09:31:46+01:00

fixup! Add CI for Tor Browser

TB 43446: Include alpha and nightly branding in the translation CI.

428bf9f4

by Richard Pospesel at 2025-03-13T09:31:46+01:00

TB 41089: Add tor-browser build scripts + Makefile to tor-browser

023c747b

by Henry Wilkes at 2025-03-13T09:31:46+01:00

TB 41803: Add some developer tools for working on tor-browser.

de2db0ef
by Alex Catarineu at 2025-03-13T09:31:46+01:00
```
Add TorStrings module for localization
```

25374848

by Henry Wilkes at 2025-03-13T09:31:47+01:00

Tor Browser strings

This commit adds all the strings needed for Tor Browser patches.

b85f9414

by Henry Wilkes at 2025-03-13T09:31:47+01:00

fixup! Tor Browser strings

TB 43462: Add a string for the "unknown" internet status.

e41755b8

by Henry Wilkes at 2025-03-13T09:31:47+01:00

fixup! Tor Browser strings

TB 43328: Improve the Tor log.

a9739751

by Henry Wilkes at 2025-03-13T09:31:47+01:00

fixup! Tor Browser strings

TB 43469: Use "Connect automatically" instead of "Quickstart" in the UI.

10251532
by Henry Wilkes at 2025-03-13T09:31:48+01:00
```
Tor Browser localization migration scripts.
```

42ba9b80

by Mike Perry at 2025-03-13T09:31:48+01:00

TB 2176: Rebrand Firefox to TorBrowser

See also Bugs #5194, #7187, #8115, #8219.

This patch does some basic renaming of Firefox to TorBrowser. The rest of the
branding is done by images and icons.

Also fix bug 27905.

Bug 25702: Update Tor Browser icon to follow design guidelines

- Updated all of the branding in /browser/branding/official with new 'stable'
icon series.
- Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and
add the source svg in the same directory
- Copied /browser/branding/official over /browser/branding/nightly and the new
/browser/branding/alpha directories. Replaced content with 'nightly' and
'alpha' icon series.
Updated VisualElements_70.png and VisualElements_150.png with updated icons in
each branding directory (fixes #22654)
- Updated firefox.VisualElementsManfiest.xml with updated colors in each
branding directory
- Added firefox.svg to each branding directory from which all the other icons
are derived (apart from document.icns and document.ico)
- Added default256.png and default512.png icons
- Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed
original icon
- Use the Tor Browser icon within devtools/client/themes/images/.

Bug 30631: Blurry Tor Browser icon on macOS app switcher

It would seem the png2icns tool does not generate correct icns files and
so on macOS the larger icons were missing resulting in blurry icons in
the OS chrome. Regenerated the padded icons in a macOS VM using
iconutil.

Bug 28196: preparations for using torbutton tor-browser-brand.ftl

A small change to Fluent FileSource class is required so that we
can register a new source without its supported locales being
counted as available locales for the browser.

Bug 31803: Replaced about:debugging logo with flat version

Bug 21724: Make Firefox and Tor Browser distinct macOS apps

When macOS opens a document or selects a default browser, it sometimes
uses the CFBundleSignature. Changing from the Firefox MOZB signature to
a different signature TORB allows macOS to distinguish between Firefox
and Tor Browser.

Bug 32092: Fix Tor Browser Support link in preferences

For bug 40562, we moved onionPattern* from bug 27476 to here, as
about:tor needs these files but it is included earlier.

Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one

Bug 42088: New application icons (used in-app and on linux).

Bug 42087: New application icons (windows).

e435d9c4

by Henry Wilkes at 2025-03-13T09:31:48+01:00

fixup! TB 2176: Rebrand Firefox to TorBrowser

TB 43466: Drop unnecessary changes to the aboutDialog.css stylesheet.

Common branding rules common to tor browser releases were moved to the
existing aboutDialogTor.css.

Duplicate rules that were already in
browser/base/content/aboutDialog.css were dropped.

Rules that only made a minor difference were dropped:

1. We now centre-align the logo, instead of right-aligning (which did
   not seem to work as intended in right-to-left locales).
2. We keep the logo at the default 192px size, rather than 180px, which
   is a 0.75 scaling of the original 256px PNG.
3. We use the default size between the wordmark and "Extended Support
   Release", which increases the gap by 6px.

6ac323b6

by Henry Wilkes at 2025-03-13T09:31:48+01:00

fixup! TB 2176: Rebrand Firefox to TorBrowser

TB 43461: Drop our wordmark padding.

5078f77d

by Henry Wilkes at 2025-03-13T09:31:49+01:00

fixup! TB 2176: Rebrand Firefox to TorBrowser

TB 43446: Change the branding name for the alpha and nightly releases.

a97854e8
by Henry Wilkes at 2025-03-13T09:31:49+01:00
```
Customize moz-toggle for tor-browser.
```

5e851124

by Henry Wilkes at 2025-03-13T09:31:49+01:00

TB 43087: Add onion-pattern to be used on Tor pages.

2e7a1f0f
by hackademix at 2025-03-13T09:31:49+01:00
```
TB 41917: Tor brand-specific styles.
```
c5e6081a
by Henry Wilkes at 2025-03-13T09:31:49+01:00
```
TB 41817: tor-browser semantic colors.
```

564e13fc

by Henry Wilkes at 2025-03-13T09:31:50+01:00

TB 42110: Add TorUIUtils module for common tor component methods.

b3810cfb
by Henry Wilkes at 2025-03-13T09:31:50+01:00
```
Add purple tor version of the loading APNG.
```

4c6d2003

by Henry Wilkes at 2025-03-13T09:31:50+01:00

TB 42583: Modify moz-support-link for Tor Browser.

35f98ae6

by sanketh at 2025-03-13T09:31:50+01:00

TB 40209: Implement Basic Crypto Safety

Adds a CryptoSafety actor which detects when you've copied a crypto
address from a HTTP webpage and shows a warning.

Closes #40209.

Bug 40428: Fix string attribute names

8ab0858f

by Mike Perry at 2025-03-13T09:31:51+01:00

TB3: Tor Browser's official .mozconfigs.

Also:
Add an --enable-tor-browser-data-outside-app-dir configure option

Add --with-tor-browser-version configure option

Bug 31457: disable per-installation profiles

The dedicated profiles (per-installation) feature does not interact
well with our bundled profiles on Linux and Windows, and it also causes
multiple profiles to be created on macOS under TorBrowser-Data.

Bug 31935: Disable profile downgrade protection.

Since Tor Browser does not support more than one profile, disable
the prompt and associated code that offers to create one when a
version downgrade situation is detected.

Add --enable-tor-browser-update build option

Bug 40793: moved Tor configuration options from old-configure.in to moz.configure

Bug 41584: Move some configuration options to base-browser level

082fa702

by Henry Wilkes at 2025-03-13T09:31:51+01:00

TB 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds

tor-browser#41285: Enable fluent warnings.

d476f0b9

by Pier Angelo Vendrame at 2025-03-13T09:31:51+01:00

TB 40562: Added Tor Browser preferences to 000-tor-browser.js

Before reordering patches, we used to keep the Tor-related patches
(torbutton and tor-launcher) at the beginning.
After that issue, we decided to move them towards the end.

In addition to that, we have decided to move Tor Browser-only
preferences there, too, to make Base Browser-only fixups easier to
apply.

ed07529c

by Pier Angelo Vendrame at 2025-03-13T09:31:51+01:00

TB 13252: Customize profile management on macOS

On macOS we allow both portable mode and system installation.
However, in the latter case, we customize Firefox's directories to
match the hierarchy we use for the portable mode.

Also, display an informative error message if the TorBrowser-Data
directory cannot be created due to an "access denied" or a
"read only volume" error.

1b54f088

by Pier Angelo Vendrame at 2025-03-13T09:31:51+01:00

TB 40933: Add tor-launcher functionality

Bug 41926: Reimplement the control port

14913a48

by Henry Wilkes at 2025-03-13T09:31:52+01:00

fixup! TB 40933: Add tor-launcher functionality

TB 43328: Make getLog return the LogEntry data.

000d560b
by Cecylia Bocovich at 2025-03-13T09:31:52+01:00
```
Lox integration
```

84ca9744

by Richard Pospesel at 2025-03-13T09:31:52+01:00

TB 40597: Implement TorSettings module

- migrated in-page settings read/write implementation from about:preferences#tor
  to the TorSettings module
- TorSettings initially loads settings from the tor daemon, and saves them to
  firefox prefs
- TorSettings notifies observers when a setting has changed; currently only
  QuickStart notification is implemented for parity with previous preference
  notify logic in about:torconnect and about:preferences#tor
- about:preferences#tor, and about:torconnect now read and write settings
  thorugh the TorSettings module
- all tor settings live in the torbrowser.settings.* preference branch
- removed unused pref modify permission for about:torconnect content page from
  AsyncPrefs.jsm

Bug 40645: Migrate Moat APIs to Moat.jsm module

2462f176

by Henry Wilkes at 2025-03-13T09:31:52+01:00

fixup! TB 40597: Implement TorSettings module

TB 43462: Use NetworkLinkService instead of Moat for the internet test.

TorConnect now exposes an `internetStatus` property, which is kept up to
date using `NetworkLinkService`.

184dec46

by Henry Wilkes at 2025-03-13T09:31:53+01:00

fixup! TB 40597: Implement TorSettings module

TB 43502: Remove about:torconnect specific methods from TorConnect
module.

73c14bc3

by Henry Wilkes at 2025-03-13T09:31:53+01:00

fixup! TB 40597: Implement TorSettings module

TB 43529: Await BootstrapAttempt.cancel in AutoBootstrapAttempt.

We also add a comment for the reason why we need to await.

64a61397

by Henry Wilkes at 2025-03-13T09:31:53+01:00

fixup! TB 40597: Implement TorSettings module

TB 43465: Replace TorConnect.canBeginBootstrap with
TorConnect.canBeginNormalBootstrap to distinguish it from
TorConnect.canBeginAutoBootstrap.

fa8df85f

by Arthur Edelstein at 2025-03-13T09:31:53+01:00

TB 3455: Add DomainIsolator, for isolating circuit by domain.

Add an XPCOM component that registers a ProtocolProxyChannelFilter
which sets the username/password for each web request according to
url bar domain.

Bug 9442: Add New Circuit button

Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ.

Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce.

Bug 19206: Clear out the domain isolator state on `New Identity`.

Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes

Bug 21745: Fix handling of catch-all circuit

Bug 41741: Refactor the domain isolator and new circuit

5e2e9eb5
by Henry Wilkes at 2025-03-13T09:31:54+01:00
```
TB 41600: Add a tor circuit display panel.
```

35263b02

by Pier Angelo Vendrame at 2025-03-13T09:31:54+01:00

TB 42247: Android helpers for the TorProvider

GeckoView is missing some API we use on desktop for the integration
with the tor daemon, such as subprocess.
Therefore, we need to implement them in Java and plumb the data
back and forth between JS and Java.

9adb0d1f

by clairehurst at 2025-03-13T09:31:54+01:00

fixup! TB 42247: Android helpers for the TorProvider

tor-browser#43408

34d3ed45

by Dan Ballard at 2025-03-13T09:31:54+01:00

fixup! TB 42247: Android helpers for the TorProvider

Rename TorIntegrationAndroid.java to TorAndroidIntegration.java

879defae

by hackademix at 2025-03-13T09:31:54+01:00

TB 8324: Prevent DNS proxy bypasses caused by Drag&Drop

Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs

11046d2b

by Matthew Finkel at 2025-03-13T09:31:55+01:00

TB 25741: TBA: Disable GeckoNetworkManager

The browser should not need information related to the network
interface or network state, tor should take care of that.

f16b096f
by Pier Angelo Vendrame at 2025-03-13T09:31:55+01:00
```
TB 40807: Added QRCode.js to toolkit/modules
```

1c0b3d60

by Richard Pospesel at 2025-03-13T09:31:55+01:00

TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

This patch adds a new about:preferences#connection page which allows
modifying bridge, proxy, and firewall settings from within Tor Browser.
All of the functionality present in tor-launcher's Network
Configuration panel is present:

 - Setting built-in bridges
 - Requesting bridges from BridgeDB via moat
 - Using user-provided bridges
 - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
 - Setting firewall ports
 - Viewing and Copying Tor's logs
 - The Networking Settings in General preferences has been removed

Bug 40774: Update about:preferences page to match new UI designs

a2ed3550

by Henry Wilkes at 2025-03-13T09:31:55+01:00

fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

TB 43462: Make the internet status in `about:preferences` update
automatically without any user input.

We listen to the status via TorConnect.

7f833747

by Henry Wilkes at 2025-03-13T09:31:56+01:00

fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

TB 43502: Move about:torconnect methods to TorConnectParent.

2d3b5ee4

by Henry Wilkes at 2025-03-13T09:31:56+01:00

fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

TB 43469: Change the quickstart checkbox to a toggle.

We also update the description text to use "connect automatically"
rather than "Quickstart".

d76a3e4a

by Henry Wilkes at 2025-03-13T09:31:56+01:00

fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection

TB 43328: Improve the Tor log dialog.

c3ab86a8

by Richard Pospesel at 2025-03-13T09:32:01+01:00

TB 27476: Implement about:torconnect captive portal within Tor Browser

- implements new about:torconnect page as tor-launcher replacement
- adds new torconnect component to browser
- tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
- adds warning/error box to about:preferences#tor when not connected to tor

Bug 40773: Update the about:torconnect frontend page to match additional UI flows.

Bug 41608: Add a toolbar status button and a urlbar "Connect" button.

5af2c826

by Henry Wilkes at 2025-03-13T09:32:01+01:00

fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser

TB 43398: Prevent tor-button CSS rules from overwriting the
tor-urlbar-button-plain class rules.

ebb69a1f

by Henry Wilkes at 2025-03-13T09:32:01+01:00

fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser

TB 43502: Move about:torconnect methods to TorConnectParent.

3d45cdb5

by Henry Wilkes at 2025-03-13T09:32:02+01:00

fixup! TB 27476: Implement about:torconnect captive portal within Tor Browser

TB 43465: Show the urlbar Connect button when the user might want to
return to about:torconnect.

Instead of hiding the button when canBeginNormalBootstrap is false we
show it as a plain button. Instead we hide it only when we are already
bootstrapped.

We also avoid initialising the button when TorConnect is not enabled.

We also update TorConnect.open:

1. Do not re-open about:torconnect if we are already connected. E.g.
   when the user selects "Connect" in a bridge dialog but we are
   already connected by the time the settings are applied.
2. Do not call TorConnect.startAgain when receiving a "hard" request.
   Only the bridge dialogs make this request, and they would have
   already triggered startAgain by changing the bridge settings.

3689d7ee

by Pier Angelo Vendrame at 2025-03-13T09:32:02+01:00

Temporary changes to about:torconnect for Android.

We are planning of tempoorarily using about:torconnect on Android, until
the native UX is ready.

3217c1d3

by Henry Wilkes at 2025-03-13T09:32:02+01:00

TB 7494: Create local home page for TBB.

Bug 41333: Update about:tor to new design. Including:
+ make the favicon match the branding icon.
+ make the location bar show a search icon.

b6a388c6

by Pier Angelo Vendrame at 2025-03-13T09:32:02+01:00

TB 41668: Tweaks to the Base Browser updater for Tor Browser

This commit was once part of "Bug 4234: Use the Firefox Update Process
for Tor Browser.".
However, some parts of it were not needed for Base Browser and some
derivative browsers.
Therefore, we extracted from that commit the parts for Tor Browser
legacy, and we add them back to the patch set with this commit.

7f57c3e6
by Kathy Brade at 2025-03-13T09:32:03+01:00
```
TB 12647: Support symlinks in the updater.
```

9c8187e2

by Georg Koppen at 2025-03-13T09:32:03+01:00

TB 32658: Create a new MAR signing key

It's time for our rotation again: Move the backup key in the front
position and add a new backup key.

Bug 33803: Move our primary nightly MAR signing key to tor-browser

Bug 33803: Add a secondary nightly MAR signing key

72f36137

by Pier Angelo Vendrame at 2025-03-13T09:32:03+01:00

TB 42891: Set the bundled search engine for Tor Browser.

After upstream changes between Firefox 115 and 128, we had to
completely rework the way in which we define our search engines.

This commit replaces the old "Omnibox: Add DDG, Startpage, Disconnect,
Youtube, Twitter; remove Amazon, eBay, bing".

With that commit, we customized a list of addons IDs to ship as
built-in search engines, but then upsteam moved to using only
RemoteSettings.
The configuration has many more fields, and it would be quite long to
include it in the source code. Therefore, we use some local JSON files
and load the settings from them.

c82602aa

by Alex Catarineu at 2025-03-13T09:32:03+01:00

TB 40073: Disable remote Public Suffix List fetching

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
fetching the Public Suffix List via RemoteSettings and replacing the default
one at runtime, which we do not want.

d4b8fc0b
by Henry Wilkes at 2025-03-13T09:32:03+01:00
```
TB 41906: Hide DNS over HTTPS preferences.
```

57cbf870

by Richard Pospesel at 2025-03-13T09:32:04+01:00

TB 23247: Communicating security expectations for .onion

Encrypting pages hosted on Onion Services with SSL/TLS is redundant
(in terms of hiding content) as all traffic within the Tor network is
already fully encrypted.  Therefore, serving HTTP pages from an Onion
Service is more or less fine.

Prior to this patch, Tor Browser would mostly treat pages delivered
via Onion Services as well as pages delivered in the ordinary fashion
over the internet in the same way.  This created some inconsistencies
in behaviour and misinformation presented to the user relating to the
security of pages delivered via Onion Services:

 - HTTP Onion Service pages did not have any 'lock' icon indicating
   the site was secure
 - HTTP Onion Service pages would be marked as unencrypted in the Page
   Info screen
 - Mixed-mode content restrictions did not apply to HTTP Onion Service
   pages embedding Non-Onion HTTP content

This patch fixes the above issues, and also adds several new 'Onion'
icons to the mix to indicate all of the various permutations of Onion
Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.

Strings for Onion Service Page Info page are pulled from Torbutton's
localization strings.

7be9e9f6

by Kathy Brade at 2025-03-13T09:32:04+01:00

TB 30237: Add v3 onion services client authentication prompt

When Tor informs the browser that client authentication is needed,
temporarily load about:blank instead of about:neterror and prompt
for the user's key.

If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
control port command to add the key (via Torbutton's control port
module) and reload the page.

If the user cancels the prompt, display the standard about:neterror
"Unable to connect" page. This requires a small change to
browser/actors/NetErrorChild.jsm to account for the fact that the
docShell no longer has the failedChannel information. The failedChannel
is used to extract TLS-related error info, which is not applicable
in the case of a canceled .onion authentication prompt.

Add a leaveOpen option to PopupNotifications.show so we can display
error messages within the popup notification doorhanger without
closing the prompt.

Add support for onion services strings to the TorStrings module.

Add support for Tor extended SOCKS errors (Tor proposal 304) to the
socket transport and SOCKS layers. Improved display of all of these
errors will be implemented as part of bug 30025.

Also fixes bug 19757:
 Add a "Remember this key" checkbox to the client auth prompt.

 Add an "Onion Services Authentication" section within the
 about:preferences "Privacy & Security section" to allow
 viewing and removal of v3 onion client auth keys that have
 been stored on disk.

Also fixes bug 19251: use enhanced error pages for onion service errors.

490cb2c7

by Alex Catarineu at 2025-03-13T09:32:04+01:00

TB 21952: Implement Onion-Location

Whenever a valid Onion-Location HTTP header (or corresponding HTML
<meta> http-equiv attribute) is found in a document load, we either
redirect to it (if the user opted-in via preference) or notify the
presence of an onionsite alternative with a badge in the urlbar.

0901d5e0

by Henry Wilkes at 2025-03-13T09:32:04+01:00

fixup! TB 21952: Implement Onion-Location

TB 43406: Hide the "onion available" button whilst the "Connect" button
is shown.

a4447152

by Pier Angelo Vendrame at 2025-03-13T09:32:05+01:00

TB 40458: Implement .tor.onion aliases

We have enabled HTTPS-Only mode, therefore we do not need
HTTPS-Everywhere anymore.
However, we want to keep supporting .tor.onion aliases (especially for
securedrop).
Therefore, in this patch we implemented the parsing of HTTPS-Everywhere
rulesets, and the redirect of .tor.onion domains.
Actually, Tor Browser believes they are actual domains. We change them
on the fly on the SOCKS proxy requests to resolve the domain, and on
the code that verifies HTTPS certificates.

98c32573

by Pier Angelo Vendrame at 2025-03-13T09:32:05+01:00

TB 11698: Incorporate Tor Browser Manual pages into Tor Browser

This patch associates the about:manual page to a translated page that
must be injected to browser/omni.ja after the build.
The content must be placed in chrome/browser/content/browser/manual/, so
that is then available at chrome://browser/content/manual/.
We preferred giving absolute freedom to the web team, rather than having
to change the patch in case of changes on the documentation.

92e93b8b

by Pier Angelo Vendrame at 2025-03-13T09:32:05+01:00

TB 41435: Add a Tor Browser migration function

For now this function only deletes old language packs for which we are
already packaging the strings with the application.

2c45a84c

by Henry Wilkes at 2025-03-13T09:32:05+01:00

fixup! TB 41435: Add a Tor Browser migration function

TB 43462: Drop preference for blocking internet tests since it no longer
requires Moat access.

42ba7154

by Dan Ballard at 2025-03-13T09:32:06+01:00

TB 40701: Add security warning when downloading a file

Shown in the downloads panel, about:downloads and places.xhtml.

b3eba9b8
by Henry Wilkes at 2025-03-13T09:32:06+01:00
```
TB 41736: Customize toolbar for tor-browser.
```

1622f290

by hackademix at 2025-03-13T09:32:06+01:00

TB 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key

8efc25a8

by Richard Pospesel at 2025-03-13T09:32:06+01:00

TB 41822: Unconditionally disable default browser UX in about:preferences

27fc9d0e

by Cecylia Bocovich at 2025-03-13T09:32:06+01:00

Temporary commit: manually place generated wasm files

These files are built reproducibly using tor-browser-build: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/715

We're manually adding them here while working on the interface, but
eventually these should be placed in the right location using
tor-browser-build.

281a684c
by Pier Angelo Vendrame at 2025-03-13T09:32:07+01:00
```
[android] TBA strings
```

fa2ebd6e

by Dan Ballard at 2025-03-13T09:32:07+01:00

TB 42660: Disable ProxySelector.openConnectionWithProxy and NOPify CrashReporter.sendCrashReport

dcc7f71e

by Dan Ballard at 2025-03-13T09:32:07+01:00

TB 43006: Disable RFP for Font Visibility on Android

35d78b32

by Matthew Finkel at 2025-03-13T09:32:07+01:00

TB 40005: [android] Modify Default toolbar menu

Originally android-components#40005.

48c6aa04

by Alex Catarineu at 2025-03-13T09:32:08+01:00

TB 34378: [android] Port external helper app prompting

Together with the corresponding fenix patch, this allows all `startActivity`
that may open external apps to be replaced by `TorUtils.startActivityPrompt`.

Originally, android-components#40007 and fenix#34378.

5f6da40c

by Alex Catarineu at 2025-03-13T09:32:08+01:00

TB 40002: [android] Ensure system download manager is not used

Originally, android-components#40002.

android-components#40075: Support scoped storage to enable downloads on API < 29

- in android-components!7,  we blocked all usage of Scoped
  Storage in an attempt to block usage of Android's
  DownloadManager, which is known to cause proxy bypasses
- as of Android API 29, downloads will not work without Scoped Storage,
  causing all downlaods to fail (see: fenix##40192)
- here, we enable usage of scoped storage for API >= 29, but block
  calls to DownloadManager on API < 29

bbca5367

by Alex Catarineu at 2025-03-13T09:32:08+01:00

TB 40009: [android] Change the default search engines

Originally, android-components#40009.

This matches the search engines from desktop, that is:
DDG as the default, then YouTube, Google, DDGOnion,
Startpage, Twitter, Wikipedia and Yahoo.

android-components#40062: Update DuckDuckGo onion search plugin

bc33a1d7

by hackademix at 2025-03-13T09:32:08+01:00

TB 42191: [android] Temporary StrictMode relaxation to clear the thumbnail cache.

b97e7804

by hackademix at 2025-03-13T09:32:09+01:00

[android] Modify add-on support

Bug 41160: One-time ultimate switch Tor Browser Android to HTTPS-Only.
Bug 41159: Remove HTTPS-Everywhere extension from Tor Browser Android.

Bug 41094: Enable HTTPS-Only Mode by default in Tor Browser Android.

Turn shouldUseHttpsOnly's default to true.

Bug 40225: Bundled extensions don't get updated with Android Tor
           Browser updates.

Bug 40030: Install NoScript addon on startup.

Also 40070: Consider storing the list of recommended addons

This implements our own AddonsProvider, which loads the list of
available addons from assets instead of fetching it from an
endpoint.

Also, we hide the uninstall button for builtin addons.

Bug 40058: Hide option for disallowing addon in private mode

20873657

by Alex Catarineu at 2025-03-13T09:32:09+01:00

[android] Modify Addon support

android-components#40011: Hide option for disallowing addons in private mode

android-components#40016: Allow inheriting from AddonCollectionProvider

This will allow implementing our own AddonsProvider in fenix.

0d675d03

by Alex Catarineu at 2025-03-13T09:32:09+01:00

TB 40015: [android] Port padlock states for .onion services

Originally, android-components#40015.

1881c71d

by Matthew Finkel at 2025-03-13T09:32:09+01:00

[android] Modify Tracking Protection configuration

android-components#40020: Disable third-party cookies

android-components#40024: Disable tracking protection by default

681a3f58

by Matthew Finkel at 2025-03-13T09:32:09+01:00

TB 40023: [android] Stop PrivateNotificationService

Originally, android-components#40023.

5a25d127

by Alex Catarineu at 2025-03-13T09:32:10+01:00

TB 34439 [android]: Isolate Icon loader on Android.

Originally, android-components#34439.

2db9375c

by Matthew Finkel at 2025-03-13T09:32:10+01:00

[android] Disable features and functionality

Bug 33594: Disable data collection by default (Glean)

Bug 40019: Adjust is disabled on Release when data collection is disabled

Bug 34338: Disable the crash reporter

Bug 40014: Neuter Google Advertising ID

Bug 40018: Disable Push service

Bug 40034: Disable PWA onboading

Bug 40072: Disable Tracking Protection

Bug 40061: Do not show "Send to device" in sharing menu

Bug 40109: Reduce requested permissions

Exclude LOCATION and NETWORK_STATE

55c1ebaf

by Matthew Finkel at 2025-03-13T09:32:10+01:00

TB 40032 [android]: Set usesCleartextTraffic as false

Originally, fenix#40032.

0042463d

by Matthew Finkel at 2025-03-13T09:32:10+01:00

[android] Rename as Tor Browser

Bug 40020: Change applicationId

Bug 40020: Change app name

Bug 40020: Change deeplink scheme

Bug 40020: Change App icons

Bug 40073: Use correct branding on About page

Bug 40088: Use Tor Browser logo in migration screen

5036e682

by Georg Koppen at 2025-03-13T09:32:11+01:00

[android] Modify build system

Bug 40083: Make locale ordering in BuildConfig deterministic

Bug 40042: Add option do overwrite timestamp in extension version

Bug 40059: Use MOZ_BUILD_DATE for versionCode

At the same time we adapt MOZ_BUILD_DATE to our needs where it is
actually used and not in tor-browser-build. This gives us more
flexibility. See: tor-browser-build#40084.

Bug 40067: Fix reproducibility issue in classes2.dex

We make sure our MOZ_BUILD_DATE gets used as a source for showing date
related information on the Fenix about page.

Bug 40071: Show only supported locales

Bug 40064: Use Gecko Beta for Nightly and Debug variants

Bug 40123: Allow building the instrumented tests apks for variants other than debug

This allows to specify the variant of the instrumented tests via
a `testBuildType` gradle argument. It also applies a workaround for
a R8 issue from https://issuetracker.google.com/issues/140851070.

Bug 40143: Use deterministic date in Test apk

The build config was using Date() when generating the Test apk's
versionName.

d5d1626f

by Dan Ballard at 2025-03-13T10:02:11+01:00

fixup! [android] Modify build system

Bug 42669: Inject gradle property for nimbus-fml path for application services

dbf3e792

by Dan Ballard at 2025-03-13T10:02:16+01:00

fixup! [android] Modify build system

Bug 43518: Fix TBB builds without topsrcdir defined

# Conflicts:
#	mobile/android/fenix/app/build.gradle

9dad881e

by Matthew Finkel at 2025-03-13T10:02:17+01:00

TB 40185: [android] Use NimbusDisabled

Originally, fenix#40185.

cdbd10ae

by Alex Catarineu at 2025-03-13T10:02:17+01:00

TB 40087 [android]: Implement a switch for spoof English.

Originally, fenix#40087 and android-components#40019.

cd22e194

by Matthew Finkel at 2025-03-13T10:02:17+01:00

TB 34403 [android]: Disable Normal mode by default.

Originally, fenix#34403.

afc12de0

by Matthew Finkel at 2025-03-13T10:02:17+01:00

TB 40016 [android]: Don't install WebCompat webext.

Originally, fenix#40016.

6ad9c6fe

by Matthew Finkel at 2025-03-13T10:02:18+01:00

[android] Modify UI/UX

Bug 40015: Modify Home menu

Bug 40016: Hide unwanted Settings

Bug 40016: Modify Default toolbar menu

Bug 40016: Add Donate settings button

Bug 40016: Move Allow Screenshots under Advanced

Bug 40016: Don't install WebCompat webext

Bug 40016: Don't onboard Search Suggestions

Bug 40094: Do not use MasterPasswordTipProvider in HomeFragment

Bug 40095: Hide "Sign in to sync" in bookmarks

Bug 40031: Hide Mozilla-specific items on About page

Bug 40063: Do not sort search engines alphabetically

Bug 40141: Hide EME site permission

Bug 40166: Hide "Normal" tab (again) and Sync tab in TabTray

Bug 40167: Hide "Save to Collection" in menu

Bug 40172: Find the Quit button

Bug 40186: Hide Credit Cards in Settings

Bug 40198: Spoof English toggle now overlaps with locale list

5c7c40a8

by Matthew Finkel at 2025-03-13T10:02:18+01:00

TB 40026 [android]: Implement Security Level settings on Android.

Originally, fenix#40026.

fd55ab20
by Dan Ballard at 2025-03-13T10:02:18+01:00
```
TB 41972: [android] Disable Mozilla onboarding
```

8ac6feee

by Dan Ballard at 2025-03-13T10:04:23+01:00

TB 41878: [android] Add standalone Tor Bootstrap

d9f9aa49

by clairehurst at 2025-03-13T10:04:24+01:00

fixup! TB 41878: [android] Add standalone Tor Bootstrap

tor-browser#43408

b3daf9c4

by Dan Ballard at 2025-03-13T10:04:24+01:00

fixup! TB 41878: [android] Add standalone Tor Bootstrap

Rename TorIntegrationAndroid.java to TorAndroidIntegration.java

4d7d2197

by Matthew Finkel at 2025-03-13T10:04:24+01:00

TB 40041 [android]: Implement Tor Network Settings

Originally, fenix#40041.

e0433f13