[tor-commits] [tor/master] Practracker beatings are even more fun when they get caused mid-PR due to a github auto-rebase of a PR

[asn@xxxxxxxxxxxxxx]

commit 5f47d582d50134d9504ec8e7a912887829904c8a
Author: Mike Perry <mikeperry-git@xxxxxxxxxxxxxx>
Date:   Wed May 15 04:58:21 2019 +0000

    Practracker beatings are even more fun when they get caused mid-PR due to a github auto-rebase of a PR
    
    Because github PRs choose the most recent origin/master at the time of the PR
    (and for any fixups pushed to a PR later to send to CI), there are tons of
    conflicts and unexpected practracker issues.
    
    This means CI can suddenly fail after fixups to a branch that pass locally.
    
    Then CI fails and we have to close and re-open the PR.
---
 scripts/maint/practracker/exceptions.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/maint/practracker/exceptions.txt b/scripts/maint/practracker/exceptions.txt
index 24452b615..b380d507b 100644
--- a/scripts/maint/practracker/exceptions.txt
+++ b/scripts/maint/practracker/exceptions.txt
@@ -289,3 +289,4 @@ problem function-size /src/tools/tor-gencert.c:parse_commandline() 111
 problem function-size /src/tools/tor-resolve.c:build_socks5_resolve_request() 104
 problem function-size /src/tools/tor-resolve.c:do_resolve() 175
 problem function-size /src/tools/tor-resolve.c:main() 112
+problem function-size /src/core/or/circuitpadding.c:circpad_machine_schedule_padding() 107



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits