[tor-commits] [tor/master] Coverage: do not include test-rebind in coverage builds.

[dgoulet@xxxxxxxxxxxxxx]

commit 07ccffa989a8c6ac6ac216b6e729daed14372620
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Wed May 15 14:58:46 2019 -0400

    Coverage: do not include test-rebind in coverage builds.
    
    Because it invokes the Tor mainloop, it does unpredictable things to
    test coverage of a lot of code that it doesn't actually test at
    all.  (It is more an integration test than anything else.)
---
 src/test/include.am | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/test/include.am b/src/test/include.am
index 824089bc4..85f9c9f88 100644
--- a/src/test/include.am
+++ b/src/test/include.am
@@ -32,8 +32,15 @@ endif
 
 if USEPYTHON
 TESTSCRIPTS += src/test/test_ntor.sh src/test/test_hs_ntor.sh src/test/test_bt.sh
+
+if COVERAGE_ENABLED
+# ...
+else
+# Only do this when coverage is not on, since it invokes lots of code
+# in a kind of unpredictable way.
 TESTSCRIPTS += src/test/test_rebind.sh
 endif
+endif
 
 TESTS += src/test/test src/test/test-slow src/test/test-memwipe \
 	src/test/test_workqueue \



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits