[tor-commits] [tor/master] Remove want_cmddata from HSFETCH, which does not in fact want data

[dgoulet@xxxxxxxxxxxxxx]

commit 2d66250d8acfc61210442df94fe04df09c2dbab6
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Wed May 29 10:10:57 2019 -0400

    Remove want_cmddata from HSFETCH, which does not in fact want data
    
    This looks a copy-and-paste error to me.  Fixes bug 30646; bugfix on
    0.4.1.1-alpha.
---
 changes/bug30646                  | 4 ++++
 src/feature/control/control_cmd.c | 1 -
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/changes/bug30646 b/changes/bug30646
new file mode 100644
index 000000000..e95a54e3e
--- /dev/null
+++ b/changes/bug30646
@@ -0,0 +1,4 @@
+  o Minor bugfixes (controller):
+    - Repair the HSFETCH command so that it works again. Previously, it
+      expected a body when it shouldn't have. Fixes bug 30646; bugfix on
+      0.4.1.1-alpha.
diff --git a/src/feature/control/control_cmd.c b/src/feature/control/control_cmd.c
index 17d5b0c7f..abb579bd4 100644
--- a/src/feature/control/control_cmd.c
+++ b/src/feature/control/control_cmd.c
@@ -1385,7 +1385,6 @@ static const control_cmd_syntax_t hsfetch_syntax = {
   .min_args = 1, .max_args = 1,
   .accept_keywords = true,
   .allowed_keywords = hsfetch_keywords,
-  .want_cmddata = true,
 };
 
 /** Implementation for the HSFETCH command. */



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits