[tor-commits] [tor/master] Fix a stupid logic-error in warnings about low ports.

[nickm@xxxxxxxxxxxxxx]

commit 11c467f6431773abaa4cced036b3bf87d4ea7f22
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Tue Nov 6 17:15:39 2012 -0500

    Fix a stupid logic-error in warnings about low ports.
    
    Instead of warning about low ports that are advertised, we should have
    been warning about low ports that we're listening on.  Bug 7285, fix
    on 0.2.3.9-alpha.
---
 changes/bug7285 |    4 ++++
 src/or/config.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/changes/bug7285 b/changes/bug7285
new file mode 100644
index 0000000..3c00205
--- /dev/null
+++ b/changes/bug7285
@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Warn when we are binding low ports when hibernation is enabled;
+      previously we had warned when we were _advertising_ low ports with
+      hibernation enabled. Fixes bug 7285; bugfix on 0.2.3.9-alpha.
diff --git a/src/or/config.c b/src/or/config.c
index dca49f5..bf32fae 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -5004,7 +5004,7 @@ check_server_ports(const smartlist_t *ports,
       continue;
     }
 #ifndef _WIN32
-    if (!port->no_advertise && port->port < 1024)
+    if (!port->no_listen && port->port < 1024)
       ++n_low_port;
 #endif
   } SMARTLIST_FOREACH_END(port);



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits