[tor-commits] [tor/master] prop224: Remove pointless unit test

[nickm@xxxxxxxxxxxxxx]

commit 791625750ef0c81b035b5c5c91ff9ab8a256df97
Author: David Goulet <dgoulet@xxxxxxxxxxxxxx>
Date:   Fri Nov 4 14:30:25 2016 -0400

    prop224: Remove pointless unit test
    
    Signed-off-by: David Goulet <dgoulet@xxxxxxxxxxxxxx>
---
 src/test/test_hs_descriptor.c | 28 ----------------------------
 1 file changed, 28 deletions(-)

diff --git a/src/test/test_hs_descriptor.c b/src/test/test_hs_descriptor.c
index e406a80..47e7037 100644
--- a/src/test/test_hs_descriptor.c
+++ b/src/test/test_hs_descriptor.c
@@ -913,32 +913,6 @@ test_decode_multiple_intro_points(void *arg)
 }
 
 static void
-test_free_objects(void *arg)
-{
-  (void) arg;
-
-  {
-    const char u[] = { 'U', 'U', 'U', 'U' };
-    hs_desc_plaintext_data_t *data = tor_malloc_zero(sizeof(*data));
-    /* Set a memory marker so we know if the data was properly wiped. */
-    memset(&data->version, 'U', sizeof(data->version));
-    hs_desc_plaintext_data_free(data);
-    tt_mem_op(&data->version, OP_NE, u, sizeof(u));
-  }
-
-  {
-    hs_desc_encrypted_data_t *data = tor_malloc_zero(sizeof(*data));
-    /* Set a memory marker so we know if the data was properly wiped. */
-    data->create2_ntor = 1;
-    hs_desc_encrypted_data_free(data);
-    tt_int_op(data->create2_ntor, OP_NE, 1);
-  }
-
- done:
-  ;
-}
-
-static void
 test_decode_plaintext(void *arg)
 {
   int ret;
@@ -1133,8 +1107,6 @@ struct testcase_t hs_descriptor[] = {
   /* Misc. */
   { "version", test_supported_version, TT_FORK,
     NULL, NULL },
-  { "free_objects", test_free_objects, TT_FORK,
-    NULL, NULL },
   { "validate_cert", test_validate_cert, TT_FORK,
     NULL, NULL },
   { "desc_signature", test_desc_signature, TT_FORK,



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits