[tor-commits] [tor/master] Explain that configuration should happen elsewhere, but not init.

[nickm@xxxxxxxxxxxxxx]

commit 4fe4bcf8a10967a668895e962099f50635ba9e4b
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Fri Nov 9 10:55:18 2018 -0500

    Explain that configuration should happen elsewhere, but not init.
---
 src/lib/subsys/subsys.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/lib/subsys/subsys.h b/src/lib/subsys/subsys.h
index b06d67e62..462314567 100644
--- a/src/lib/subsys/subsys.h
+++ b/src/lib/subsys/subsys.h
@@ -44,6 +44,9 @@ typedef struct subsys_fns_t {
    * This function MUST NOT rely on any runtime configuration information;
    * it is only for global state or pre-configuration state.
    *
+   * (If you need to do any setup that depends on configuration, you'll need
+   * to declare a configuration callback. (Not yet designed))
+   *
    * This function MUST NOT have any parts that can fail.
    **/
   int (*initialize)(void);



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits