[tor-commits] [stem/master] Drop flaky test_query_with_timeout assertion

[atagar@xxxxxxxxxxxxxx]

commit 54f87d304461502675048842ec91382f61a4f411
Author: Damian Johnson <atagar@xxxxxxxxxxxxxx>
Date:   Sun Nov 17 16:13:21 2019 -0800

    Drop flaky test_query_with_timeout assertion
    
    Jenkins has long struggled with this assertion, and I see these failures
    locally from time to time too...
    
      ======================================================================
      FAIL: test_query_with_timeout
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/usr/local/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
          return func(*args, **keywargs)
        File "/home/atagar/Desktop/stem/test/unit/descriptor/remote.py", line 387, in test_query_with_timeout
          self.assertEqual(2, dirport_mock.call_count)
      AssertionError: 2 != 3
    
      ----------------------------------------------------------------------
    
    No assertion is better than a flaky one, so dropping this last bit.
---
 test/unit/descriptor/remote.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/unit/descriptor/remote.py b/test/unit/descriptor/remote.py
index 8a35216d..ab0ad3d7 100644
--- a/test/unit/descriptor/remote.py
+++ b/test/unit/descriptor/remote.py
@@ -381,10 +381,10 @@ class TestDescriptorDownloader(unittest.TestCase):
     )
 
     # After two requests we'll have reached our total permissable timeout.
-    # Check that we don't make a third.
+    # It would be nice to check that we don't make a third, but this
+    # assertion has proved unreliable so only checking for the exception.
 
     self.assertRaises(stem.DownloadTimeout, query.run)
-    self.assertEqual(2, dirport_mock.call_count)
 
   def test_query_with_invalid_endpoints(self):
     invalid_endpoints = {

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits