[or-cvs] improve INFO-level logging for directory downloads. This i...

[nickm@xxxxxxxx (Nick Mathewson)]

Update of /home/or/cvsroot/tor/src/or
In directory moria:/tmp/cvs-serv11503/src/or

Modified Files:
	directory.c routerlist.c 
Log Message:
improve INFO-level logging for directory downloads.  This is still too chatty, but it will help us analyze things.

Index: directory.c
===================================================================
RCS file: /home/or/cvsroot/tor/src/or/directory.c,v
retrieving revision 1.302
retrieving revision 1.303
diff -u -d -r1.302 -r1.303
--- directory.c	5 Oct 2005 04:52:55 -0000	1.302
+++ directory.c	5 Oct 2005 20:45:18 -0000	1.303
@@ -1633,13 +1633,13 @@
       }
     }
     if (rs->next_attempt_at == 0)
-      log_fn(LOG_INFO, "%s failed %d time(s); I'll try again immediately.",
+      log_fn(LOG_DEBUG, "%s failed %d time(s); I'll try again immediately.",
              cp, (int)rs->n_download_failures);
     else if (rs->next_attempt_at < TIME_MAX)
-      log_fn(LOG_INFO, "%s failed %d time(s); I'll try again in %d seconds.",
+      log_fn(LOG_DEBUG, "%s failed %d time(s); I'll try again in %d seconds.",
              cp, (int)rs->n_download_failures, (int)(rs->next_attempt_at-now));
     else
-      log_fn(LOG_INFO, "%s failed %d time(s); Giving up for a while.",
+      log_fn(LOG_DEBUG, "%s failed %d time(s); Giving up for a while.",
              cp, (int)rs->n_download_failures);
   });
 

Index: routerlist.c
===================================================================
RCS file: /home/or/cvsroot/tor/src/or/routerlist.c,v
retrieving revision 1.330
retrieving revision 1.331
diff -u -d -r1.330 -r1.331
--- routerlist.c	5 Oct 2005 05:03:52 -0000	1.330
+++ routerlist.c	5 Oct 2005 20:45:18 -0000	1.331
@@ -2538,12 +2538,13 @@
 {
 #define MAX_OLD_SERVER_DOWNLOAD_RATE 2*60*60
   int n_conns, i, n_downloadable = 0;
-  int n_uptodate=0,n_skip_old=0;
   connection_t **carray;
   smartlist_t *superseded = smartlist_create();
   smartlist_t *downloading;
   time_t now = time(NULL);
   int mirror = server_mode(get_options()) && get_options()->DirPort;
+  /* these are just used for logging */
+  int n_not_ready = 0, n_in_progress = 0, n_uptodate = 0, n_skip_old = 0;
 
   if (!routerstatus_list)
     return superseded;
@@ -2565,6 +2566,7 @@
              (int)(rs->next_attempt_at-now));
       */
       rs->should_download = 0;
+      ++n_not_ready;
     }
   });
 
@@ -2595,6 +2597,7 @@
       if ((rs = router_get_combined_status_by_digest(d)) && rs->should_download) {
         rs->should_download = 0;
         --n_downloadable;
+        ++n_in_progress;
         // log_fn(LOG_NOTICE, "%s is in-progress; not fetching", dl);
       }
     });
@@ -2604,7 +2607,7 @@
   if (!n_downloadable)
     return superseded;
 
-  if (routerlist) {
+  if (routerlist && n_downloadable) {
     SMARTLIST_FOREACH(routerlist->routers, routerinfo_t *, ri,
     {
       local_routerstatus_t *rs;
@@ -2648,8 +2651,11 @@
     });
   }
 
-  if (n_skip_old)
-    log_fn(LOG_INFO, "Skipped %d updatable pre-0.1.1.6 servers.", n_skip_old);
+  log_fn(LOG_INFO, "%d router descriptors are downloadable; "
+         "%d are up to date; %d are in progress; "
+         "%d are not ready to retry; "
+         "%d are running pre-0.1.1.6 Tors and aren't stale enough to replace.",
+         n_downloadable, n_uptodate, n_in_progress, n_not_ready, n_skip_old);
 
   if (!n_downloadable)
     return superseded;
@@ -2699,16 +2705,26 @@
 
   downloadable = router_list_downloadable();
   n_downloadable = smartlist_len(downloadable);
-  if (n_downloadable >= MAX_DL_TO_DELAY)
+  if (n_downloadable >= MAX_DL_TO_DELAY) {
+    log_fn(LOG_DEBUG,
+           "There are enough downloadable routerdescs to launch requests.");
     should_delay = 0;
-  else if (n_downloadable == 0)
+  } else if (n_downloadable == 0) {
+    log_fn(LOG_DEBUG, "No routerdescs need to be downloaded.");
     should_delay = 1;
-  else if (dirserv)
-    should_delay = (last_routerdesc_download_attempted +
-                    MAX_SERVER_INTERVAL_WITHOUT_REQUEST) < now;
-  else
-    should_delay = (last_routerdesc_download_attempted +
-                    MAX_CLIENT_INTERVAL_WITHOUT_REQUEST) < now;
+  } else {
+    if (dirserv) {
+      should_delay = (last_routerdesc_download_attempted +
+                      MAX_SERVER_INTERVAL_WITHOUT_REQUEST) < now;
+    } else {
+      should_delay = (last_routerdesc_download_attempted +
+                      MAX_CLIENT_INTERVAL_WITHOUT_REQUEST) < now;
+    }
+    if (should_delay)
+      log_fn(LOG_INFO, "There are not many downloadable routerdescs; waiting till we have some more.");
+    else
+      log_fn(LOG_INFO, "There are not many downloadable routerdescs, but we've been waiting long enough. Downloading.");
+  }
 
   if (! should_delay) {
     int i, j, n_per_request=MAX_DL_PER_REQUEST;