[tor-commits] [tor-browser] 17/36: Bug 1792882 - test_interfaces.js should not check pref values. r=smaug, a=test-only

[gitolite role via tor-commits <tor-commits@xxxxxxxxxxxxxxxxxxxx>]

This is an automated email from the git hooks/post-receive script.

pierov pushed a commit to annotated tag FIREFOX_102_4_0esr_BUILD1
in repository tor-browser.

commit f1fd4e6b8661370701e7867d91b1fc6e5230909f
Author: Peter Van der Beken <peterv@xxxxxxxxxxxxxxxx>
AuthorDate: Fri Sep 30 06:39:09 2022 +0000

    Bug 1792882 - test_interfaces.js should not check pref values. r=smaug, a=test-only
    
    Differential Revision: https://phabricator.services.mozilla.com/D158359
---
 dom/tests/mochitest/general/test_interfaces.js | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/dom/tests/mochitest/general/test_interfaces.js b/dom/tests/mochitest/general/test_interfaces.js
index 61a9a0bab975..169c2f795934 100644
--- a/dom/tests/mochitest/general/test_interfaces.js
+++ b/dom/tests/mochitest/general/test_interfaces.js
@@ -3,6 +3,13 @@
 // This is a list of all interfaces that are exposed to every webpage.
 // Please only add things to this list with great care and proper review
 // from the associated module peers.
+//
+// The test is supposed to check whether our actual exposure behavior
+// matches what we expect, with the latter expressed in terms of outside
+// observables like type of build (nightly, release), platform, secure
+// context, etc. Testing based on prefs is thus the wrong check, as this
+// means we'd also have to test whether the pref value matches what we
+// expect in terms of outside observables.
 
 // This file lists global interfaces we want exposed and verifies they
 // are what we intend. Each entry in the arrays below can either be a
@@ -669,9 +676,7 @@ var interfaceNamesInGlobalScope = [
   {
     name: "InstallTrigger",
     insecureContext: true,
-    disabled: !SpecialPowers.Services.prefs.getBoolPref(
-      "extensions.InstallTrigger.enabled"
-    ),
+    disabled: isEarlyBetaOrEarlier,
   },
   // IMPORTANT: Do not change this list without review from a DOM peer!
   { name: "IntersectionObserver", insecureContext: true },

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits