[tor-commits] [tor-browser] branch tor-browser-102.4.0esr-12.0-1 updated: Bug 41371: Temporary hack to fix language selector popup position

[gitolite role via tor-commits <tor-commits@xxxxxxxxxxxxxxxxxxxx>]

This is an automated email from the git hooks/post-receive script.

pierov pushed a commit to branch tor-browser-102.4.0esr-12.0-1
in repository tor-browser.

The following commit(s) were added to refs/heads/tor-browser-102.4.0esr-12.0-1 by this push:
     new 5aff5d2b553b Bug 41371: Temporary hack to fix language selector popup position
5aff5d2b553b is described below

commit 5aff5d2b553bbc3e42fc6ae797f8b31d87dffd33
Author: Henry Wilkes <henry@xxxxxxxxxxxxxx>
AuthorDate: Thu Oct 20 18:19:28 2022 +0100

    Bug 41371: Temporary hack to fix language selector popup position
---
 browser/components/preferences/main.js | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/browser/components/preferences/main.js b/browser/components/preferences/main.js
index 7586816a0450..eab384264c4e 100644
--- a/browser/components/preferences/main.js
+++ b/browser/components/preferences/main.js
@@ -996,6 +996,23 @@ var gMainPane = {
       gMainPane.onPrimaryBrowserLanguageMenuChange(event);
     });
 
+    // Temporary hack to cause the menu popup to resize itself just after being
+    // shown. See tor-browser#41371
+    // We get ~one frame of a potentially badly sized popup, and then the popup
+    // should re-adjust to the new size.
+    // TODO: Remove with firefox 115 since this is fixed properly in
+    // mozilla-central 107.
+    menulist.addEventListener("popupshown", () => {
+      const popupBox = menulist.menupopup;
+      // We change a layout parameter and then force a relayout. We choose
+      // "min-height: 0" since we expect this won't change the displayed result
+      // but is enough to force the relayout.
+      const minHeight = popupBox.style.minHeight;
+      popupBox.style.minHeight = 0;
+      popupBox.getBoundingClientRect();
+      popupBox.style.minHeight = minHeight;
+    });
+
     gMainPane.updatePrimaryBrowserLanguageUI(Services.locale.appLocaleAsBCP47);
   },
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits