[tor-commits] [tor/master] Type bug in shared_random_state -- make sure Version is int.

[nickm@xxxxxxxxxxxxxx]

commit 49d2346b805b09fde656d05a6bbf1c632a8eb903
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Sep 25 11:52:57 2017 -0400

    Type bug in shared_random_state -- make sure Version is int.
    
    The confparse field has type UINT, which corresponds to an int
    type.  We had uint32_t.
    
    This shouldn't cause trouble in practice, since int happens to
    4-bytes wide on every platform where an authority is running.  It's
    still wrong, though.
---
 src/or/shared_random_state.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/or/shared_random_state.h b/src/or/shared_random_state.h
index a154eb563..b6af6e172 100644
--- a/src/or/shared_random_state.h
+++ b/src/or/shared_random_state.h
@@ -77,7 +77,7 @@ typedef struct sr_state_t {
 typedef struct sr_disk_state_t {
   uint32_t magic_;
   /* Version of the protocol. */
-  uint32_t Version;
+  int Version;
   /* Version of our running tor. */
   char *TorVersion;
   /* Creation time of this state */



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits