[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-153.3.0esr-16.0-1] 2 commits: BB 45249: Remove the duplicate "Verified by" from the old site identity panel.

Title: GitLab

henry pushed to branch tor-browser-153.3.0esr-16.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 18e1b0a6
    by Henry Wilkes at 2026-09-17T16:47:40+01:00 
    BB 45249: Remove the duplicate "Verified by" from the old site identity panel.
  • 088c60ee
    by Henry Wilkes at 2026-09-17T16:49:05+01:00 
    fixup! TB 23247: Communicating security expectations for .onion

TB 45249: Hide verifier information when it is empty.

Special thanks to @soni.

3 changed files:

Changes:

  • browser/base/content/browser-siteIdentity.js
    ... ... @@ -1203,16 +1203,21 @@ var gIdentityHandler = {
    1203 1203 
         let owner = "";
    1204 1204
    1205 1205 
         // Fill in the CA name if we have a valid TLS certificate.
    1206 
    -    if (this._isSecureConnection || this._isCertUserOverridden) {
    1207 
    -      verifier = this._identityIconLabel.tooltipText;
    1206 
    +    if (
    1207 
    +      this._secInfo &&
    1208 
    +      (this._isSecureConnection || this._isCertUserOverridden)
    1209 
    +    ) {
    1210 
    +      // Remove "Verified by " from the verifier string. tor-browser#45249.
    1211 
    +      verifier = this.getIdentityData().caOrg;
    1208 1212 
         }
    1209 1213
    1210 1214 
         // Fill in organization information if we have a valid EV certificate or
    1211 1215 
         // QWAC.
    1212 
    -    if (this._isEV || this._qwac) {
    1216 
    +    if (this._secInfo && (this._isEV || this._qwac)) {
    1213 1217 
           let iData = this.getIdentityData(this._qwac || this._secInfo.serverCert);
    1214 1218 
           owner = iData.subjectOrg;
    1215 
    -      verifier = this._identityIconLabel.tooltipText;
    1219 
    +      // Remove "Verified by " from the verifier string. tor-browser#45249.
    1220 
    +      verifier = iData.caOrg;
    1216 1221
    1217 1222 
           // Build an appropriate supplemental block out of whatever location data we have
    1218 1223 
           if (iData.city) {
    ... ... @@ -1263,6 +1268,12 @@ var gIdentityHandler = {
    1263 1268 
         this._identityPopupContentOwner.textContent = owner;
    1264 1269 
         this._identityPopupContentSupp.textContent = supplemental;
    1265 1270 
         this._identityPopupContentVerif.textContent = verifier;
    1271 
    +
    1272 
    +    // Hide "Verified by" section if this is empty for an onion host.
    1273 
    +    // tor-browser#45249.
    1274 
    +    document
    1275 
    +      .getElementById("identity-popup-securityView-extended-info")
    1276 
    +      .toggleAttribute("noverifier", this._uriIsOnionHost && verifier === "");
    1266 1277 
       },
    1267 1278
    1268 1279 
       setURI(uri) {

  • browser/components/controlcenter/content/securityInformation.inc.xhtml
    ... ... @@ -36,9 +36,11 @@
    36 36 
                                when-connection="secure-ev secure-etsi"/>
    37 37 
                   <description id="identity-popup-content-verifier-label"
    38 38 
                                when-connection="secure secure-ev secure-etsi"
    39 
    +                           when-verifier="true"
    39 40 
                                data-l10n-id="identity-verifier-label"/>
    40 41 
                   <description id="identity-popup-content-verifier"
    41 42 
                                when-connection="secure secure-ev secure-etsi"
    43 
    +                           when-verifier="true"
    42 44 
                                class="header"/>
    43 45 
                   <description id="identity-popup-content-etsi"
    44 46 
                                when-connection="secure-etsi"

  • browser/themes/shared/controlcenter/panel.css
    ... ... @@ -109,6 +109,11 @@
    109 109 
       display: none;
    110 110 
     }
    111 111
    112 
    +/* Hide verifier information. tor-browser#45249. */
    113 
    +#identity-popup-securityView-extended-info[noverifier] description[when-verifier] {
    114 
    +  display: none !important;
    115 
    +}
    116 
    +
    112 117 
     /* Make sure hidden elements don't accidentally become visible from one of the
    113 118 
        above selectors (see Bug 1194258) */
    114 119 
     #identity-popup [hidden] {

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help Notification message regarding https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/fd1c191475d097be2fbd960c1a2c6e7c97400d81...088c60eefcfb85c5725e2cd995b89a1fc7d1146c at 1789661090 

    _______________________________________________
tor-commits mailing list -- tor-commits@xxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to tor-commits-leave@xxxxxxxxxxxxxxxxxxxx