[or-cvs] r10036: In options_init_from_torrc()'s error path only config_free() (in tor/branches/tor-0_1_2-patches/debian: . patches)

[weasel@xxxxxxxx]

Author: weasel
Date: 2007-04-27 07:07:22 -0400 (Fri, 27 Apr 2007)
New Revision: 10036

Modified:
   tor/branches/tor-0_1_2-patches/debian/changelog
   tor/branches/tor-0_1_2-patches/debian/patches/06_add_compile_time_defaults.dpatch
Log:
In options_init_from_torrc()'s error path only config_free() options if they
already have been initialized (closes: #421235).


Modified: tor/branches/tor-0_1_2-patches/debian/changelog
===================================================================
--- tor/branches/tor-0_1_2-patches/debian/changelog	2007-04-27 10:26:09 UTC (rev 10035)
+++ tor/branches/tor-0_1_2-patches/debian/changelog	2007-04-27 11:07:22 UTC (rev 10036)
@@ -1,3 +1,10 @@
+tor (0.1.2.13-2) unstable; urgency=low
+
+  * In options_init_from_torrc()'s error path only config_free() options
+    if they already have been initialized (closes: #421235).
+
+ -- Peter Palfrader <weasel@xxxxxxxxxx>  Fri, 27 Apr 2007 13:06:37 +0200
+
 tor (0.1.2.13-1) unstable; urgency=low
 
   * New upstream version.

Modified: tor/branches/tor-0_1_2-patches/debian/patches/06_add_compile_time_defaults.dpatch
===================================================================
--- tor/branches/tor-0_1_2-patches/debian/patches/06_add_compile_time_defaults.dpatch	2007-04-27 10:26:09 UTC (rev 10035)
+++ tor/branches/tor-0_1_2-patches/debian/patches/06_add_compile_time_defaults.dpatch	2007-04-27 11:07:22 UTC (rev 10036)
@@ -23,9 +23,9 @@
 exit 0
 
 @DPATCH@
-diff -urNad tor~/src/or/config.c tor/src/or/config.c
---- tor~/src/or/config.c	2006-07-23 19:31:29.000000000 +0200
-+++ tor/src/or/config.c	2006-07-24 05:13:19.924871985 +0200
+diff -urNad tor-debian~/src/or/config.c tor-debian/src/or/config.c
+--- tor-debian~/src/or/config.c	2007-03-06 21:52:33.000000000 +0100
++++ tor-debian/src/or/config.c	2007-04-27 13:05:42.420147495 +0200
 @@ -12,6 +12,7 @@
   **/
  
@@ -34,8 +34,8 @@
  #ifdef MS_WINDOWS
  #include <shlobj.h>
  #endif
-@@ -396,6 +397,10 @@
- static void check_libevent_version(const char *m, const char *v, int server);
+@@ -592,6 +593,10 @@
+ static void check_libevent_version(const char *m, int server);
  #endif
  
 +static int debian_running_as_debiantor();
@@ -44,8 +44,8 @@
 +
  /*static*/ or_options_t *options_new(void);
  
- #define OR_OPTIONS_MAGIC 9090909
-@@ -2663,7 +2668,7 @@
+ /** Magic value for or_options_t. */
+@@ -2982,7 +2987,7 @@
  int
  options_init_from_torrc(int argc, char **argv)
  {
@@ -54,7 +54,7 @@
    config_line_t *cl;
    char *cf=NULL, *fname=NULL, *errmsg=NULL;
    int i, retval;
-@@ -2671,6 +2676,9 @@
+@@ -2991,6 +2996,9 @@
    static char **backup_argv;
    static int backup_argc;
  
@@ -64,7 +64,17 @@
    if (argv) { /* first time we're called. save commandline args */
      backup_argv = argv;
      backup_argc = argc;
-@@ -3948,3 +3956,52 @@
+@@ -3120,7 +3128,8 @@
+  err:
+   tor_free(fname);
+   torrc_fname = NULL;
+-  config_free(&options_format, newoptions);
++  if (newoptions)
++    config_free(&options_format, newoptions);
+   if (errmsg) {
+     log(LOG_WARN,LD_CONFIG,"Failed to parse/validate config: %s", errmsg);
+     tor_free(errmsg);
+@@ -4306,3 +4315,52 @@
    puts(routerparse_c_id);
  }