[tor-commits] [tor/master] scan-build: Fix harmless sizeof(ptr) in test_oom.c

[nickm@xxxxxxxxxxxxxx]

commit 1800e79ca508e555d43eb8ca36e9544f42c98944
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Sat Apr 19 12:50:17 2014 -0400

    scan-build: Fix harmless sizeof(ptr) in test_oom.c
    
    We meant to using random bytes to fill a buffer, up to 3000 at a
    time. Instead we were taking them sizeof(void*) at a time.
---
 src/test/test_oom.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/test_oom.c b/src/test/test_oom.c
index cc6e532..989ca12 100644
--- a/src/test/test_oom.c
+++ b/src/test/test_oom.c
@@ -82,8 +82,8 @@ add_bytes_to_buf(generic_buffer_t *buf, size_t n_bytes)
   char b[3000];
 
   while (n_bytes) {
-    size_t this_add = n_bytes > sizeof(buf) ? sizeof(buf) : n_bytes;
-    crypto_rand(b, sizeof(b));
+    size_t this_add = n_bytes > sizeof(b) ? sizeof(b) : n_bytes;
+    crypto_rand(b, this_add);
     generic_buffer_add(buf, b, this_add);
     n_bytes -= this_add;
   }



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits