[tor-commits] [tor/master] Fix some no-longer-reasonable unit tests for base64_decode()

[nickm@xxxxxxxxxxxxxx]

commit f5258045c4cab07eea443563cac7608d5d3be5ab
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Apr 10 12:08:31 2017 -0400

    Fix some no-longer-reasonable unit tests for base64_decode()
    
    These tests tried to use ridiculously large buffer sizes to check
    the sanity-checking in the code; but since the sanity-checking
    changed, these need to change too.
---
 src/test/test_util_format.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/test/test_util_format.c b/src/test/test_util_format.c
index dd52e4b..ea0a864 100644
--- a/src/test/test_util_format.c
+++ b/src/test/test_util_format.c
@@ -202,13 +202,10 @@ test_util_format_base64_decode(void *ignored)
     src[i] = (char)i;
   }
 
-  res = base64_decode(dst, 1, src, SIZE_T_CEILING);
+  res = base64_decode(dst, 1, src, 100);
   tt_int_op(res, OP_EQ, -1);
 
-  res = base64_decode(dst, SIZE_T_CEILING+1, src, 10);
-  tt_int_op(res, OP_EQ, -1);
-
-  res = base64_decode(dst, 1, real_src, SIZE_MAX/3+1);
+  res = base64_decode(dst, 1, real_src, 10);
   tt_int_op(res, OP_EQ, -1);
 
   const char *s = "T3BhIG11bmRv";

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits