[tor-commits] [tor/master] tests: Make tt_finished() macro for tests without tt_*_op() calls.

[nickm@xxxxxxxxxxxxxx]

commit 3ee7a8d3a545633c578e059687f7683c43108a10
Author: Isis Lovecruft <isis@xxxxxxxxxxxxxx>
Date:   Thu Mar 29 23:27:42 2018 +0000

    tests: Make tt_finished() macro for tests without tt_*_op() calls.
---
 src/test/test.h         | 8 ++++++++
 src/test/test_bridges.c | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/test/test.h b/src/test/test.h
index 91c8d3ebd..1eb3b6a2e 100644
--- a/src/test/test.h
+++ b/src/test/test.h
@@ -72,6 +72,14 @@
     I64_PRINTF_TYPE, I64_FORMAT,                                       \
     {print_ = (I64_PRINTF_TYPE) value_;}, {}, TT_EXIT_TEST_FUNCTION)
 
+/**
+ * Declare that the test is done, even though no tt___op() calls were made.
+ *
+ * For use when you only want to test calling something, but not check
+ * any values/pointers/etc afterwards.
+ */
+#define tt_finished() TT_EXIT_TEST_FUNCTION
+
 const char *get_fname(const char *name);
 const char *get_fname_rnd(const char *name);
 struct crypto_pk_t *pk_generate(int idx);
diff --git a/src/test/test_bridges.c b/src/test/test_bridges.c
index aada363d9..b5bd27e09 100644
--- a/src/test/test_bridges.c
+++ b/src/test/test_bridges.c
@@ -107,7 +107,7 @@ static void
 test_bridges_helper_func_add_bridges_to_bridgelist(void *arg)
 {
   helper_add_bridges_to_bridgelist(arg);
-  tt_int_op(0, OP_EQ, 0);
+  tt_finished();
 
  done:
   mark_bridge_list();



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits